]> www.infradead.org Git - users/dwmw2/qemu.git/commitdiff
char-socket: correctly set has_reconnect when parsing QemuOpts
authorMarc-André Lureau <marcandre.lureau@redhat.com>
Tue, 17 Jul 2018 12:43:51 +0000 (14:43 +0200)
committerMarc-André Lureau <marcandre.lureau@redhat.com>
Thu, 1 Nov 2018 08:12:09 +0000 (12:12 +0400)
qemu_chr_parse_socket() fills all ChardevSocket fields, but that
doesn't reflect correctly the arguments given with the options / on
the command line. "reconnect" takes a number as argument, and the
default value is 0, which doesn't help to identify the missing
option. The other arguments have default values that are less
problematic, leave them set by default for now.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
chardev/char-socket.c

index a75b46d9fe2d2847d1a24f43887a44775bb67d58..64e24cb2ab677368f8ab523aa3704799f6b55e91 100644 (file)
@@ -1117,7 +1117,7 @@ static void qemu_chr_parse_socket(QemuOpts *opts, ChardevBackend *backend,
     sock->tn3270 = is_tn3270;
     sock->has_wait = true;
     sock->wait = is_waitconnect;
-    sock->has_reconnect = true;
+    sock->has_reconnect = qemu_opt_find(opts, "reconnect");
     sock->reconnect = reconnect;
     sock->tls_creds = g_strdup(tls_creds);