]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
Btrfs: add missing brelse when superblock checksum fails
authorAnand Jain <anand.jain@oracle.com>
Wed, 7 Oct 2015 09:23:23 +0000 (17:23 +0800)
committerChuck Anderson <chuck.anderson@oracle.com>
Thu, 26 May 2016 22:45:50 +0000 (15:45 -0700)
Orabug: 23331023

[ Upstream commit b2acdddfad13c38a1e8b927d83c3cf321f63601a ]

Looks like oversight, call brelse() when checksum fails. Further down the
code, in the non error path, we do call brelse() and so we don't see
brelse() in the goto error paths.

Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
(cherry picked from commit c0109d289de5a48e54a2d070981a629fc241f112)

Signed-off-by: Dan Duval <dan.duval@oracle.com>
fs/btrfs/disk-io.c

index 99e8f60c796201345b3e8a7260b9008135f4c190..cea54ea9e5dfb0e5ffa02ee91ed9312c265a9916 100644 (file)
@@ -2622,6 +2622,7 @@ int open_ctree(struct super_block *sb,
        if (btrfs_check_super_csum(bh->b_data)) {
                printk(KERN_ERR "BTRFS: superblock checksum mismatch\n");
                err = -EINVAL;
+               brelse(bh);
                goto fail_alloc;
        }