]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
serdev: Use of_property_present()
authorRob Herring (Arm) <robh@kernel.org>
Wed, 31 Jul 2024 19:12:55 +0000 (13:12 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 7 Aug 2024 11:08:14 +0000 (13:08 +0200)
Use of_property_present() to test for property presence rather than
of_get_property(). This is part of a larger effort to remove callers
of of_get_property() and similar functions. of_get_property() leaks
the DT property data pointer which is a problem for dynamically
allocated nodes which may be freed.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Link: https://lore.kernel.org/r/20240731191312.1710417-17-robh@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serdev/core.c

index 8913cdd675f6bd72732c17ab2b887bad8af32bf7..ebf0bbc2cff2ed851533ea1178789adc9e9ebd7f 100644 (file)
@@ -529,7 +529,7 @@ static int of_serdev_register_devices(struct serdev_controller *ctrl)
        bool found = false;
 
        for_each_available_child_of_node(ctrl->dev.of_node, node) {
-               if (!of_get_property(node, "compatible", NULL))
+               if (!of_property_present(node, "compatible"))
                        continue;
 
                dev_dbg(&ctrl->dev, "adding child %pOF\n", node);