xfs: remove attr fork handling in xfs_bmap_finish_one

We never do COW operations for the attr fork, so don't pretend we handle
them.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
index 2a426d127e050c9fe4dcff540bb995b5dba1047b..b95e66fd0935329772ae798a1e402ad102404f03 100644 (file)
--- a/fs/xfs/libxfs/xfs_bmap.c
+++ b/fs/xfs/libxfs/xfs_bmap.c
@@ -6491,7 +6491,6 @@ xfs_bmap_finish_one(
        struct xfs_bmbt_irec            bmap;
        int                             nimaps = 1;
        xfs_fsblock_t                   firstfsb;
-       int                             flags = XFS_BMAPI_REMAP;
        int                             done;
        int                             error = 0;
 
@@ -6505,10 +6504,8 @@ xfs_bmap_finish_one(
                        XFS_FSB_TO_AGBNO(tp->t_mountp, startblock),
                        ip->i_ino, whichfork, startoff, blockcount, state);
 
-       if (whichfork != XFS_DATA_FORK && whichfork != XFS_ATTR_FORK)
+       if (WARN_ON_ONCE(whichfork != XFS_DATA_FORK))
                return -EFSCORRUPTED;
-       if (whichfork == XFS_ATTR_FORK)
-               flags |= XFS_BMAPI_ATTRFORK;
 
        if (XFS_TEST_ERROR(false, tp->t_mountp,
                        XFS_ERRTAG_BMAP_FINISH_ONE,
@@ -6519,13 +6516,13 @@ xfs_bmap_finish_one(
        case XFS_BMAP_MAP:
                firstfsb = bmap.br_startblock;
                error = xfs_bmapi_write(tp, ip, bmap.br_startoff,
-                                       bmap.br_blockcount, flags, &firstfsb,
+                                       bmap.br_blockcount, XFS_BMAPI_REMAP, &firstfsb,
                                        bmap.br_blockcount, &bmap, &nimaps,
                                        dfops);
                break;
        case XFS_BMAP_UNMAP:
                error = xfs_bunmapi(tp, ip, bmap.br_startoff,
-                               bmap.br_blockcount, flags, 1, &firstfsb,
+                               bmap.br_blockcount, XFS_BMAPI_REMAP, 1, &firstfsb,
                                dfops, &done);
                ASSERT(done);
                break;