net: sfp: provide a definition for the power level select bit

Provide a named definition for the power level select bit in the
extended status register, rather than using BIT(0) in the code.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index af676e28ba6ab7e6da9e69972b36c8bb1b777271..16bce0ea68d9b2fce47db25e044d4f908cad6cb3 100644 (file)
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -1837,13 +1837,13 @@ static int sfp_sm_mod_hpower(struct sfp *sfp, bool enable)
         * all bytes 0xff) at 0x51 but does not accept writes.  In any case,
         * if the bit is already set, we're already in high power mode.
         */
-       if (!!(val & BIT(0)) == enable)
+       if (!!(val & SFP_EXT_STATUS_PWRLVL_SELECT) == enable)
                return 0;
 
        if (enable)
-               val |= BIT(0);
+               val |= SFP_EXT_STATUS_PWRLVL_SELECT;
        else
-               val &= ~BIT(0);
+               val &= ~SFP_EXT_STATUS_PWRLVL_SELECT;
 
        err = sfp_write(sfp, true, SFP_EXT_STATUS, &val, sizeof(val));
        if (err != sizeof(val)) {

diff --git a/include/linux/sfp.h b/include/linux/sfp.h
index d1f343853b6c7383e22146e5588367e6d6524dcf..01ae9f1dd2ad772b193b0fd4ddc69a8895c170d7 100644 (file)
--- a/include/linux/sfp.h
+++ b/include/linux/sfp.h
@@ -489,6 +489,8 @@ enum {
        SFP_WARN1_RXPWR_LOW             = BIT(6),
 
        SFP_EXT_STATUS                  = 0x76,
+       SFP_EXT_STATUS_PWRLVL_SELECT    = BIT(0),
+
        SFP_VSL                         = 0x78,
        SFP_PAGE                        = 0x7f,
 };