]> www.infradead.org Git - users/dwmw2/qemu.git/commitdiff
target/i386: Change unavail from u32 to u64
authorXiong Zhang <xiong.y.zhang@linux.intel.com>
Tue, 30 Jul 2024 08:29:27 +0000 (16:29 +0800)
committerPaolo Bonzini <pbonzini@redhat.com>
Wed, 31 Jul 2024 11:13:31 +0000 (13:13 +0200)
The feature word 'r' is a u64, and "unavail" is a u32, the operation
'r &= ~unavail' clears the high 32 bits of 'r'. This causes many vmx cases
in kvm-unit-tests to fail. Changing 'unavail' from u32 to u64 fixes this
issue.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2442
Fixes: 0b2757412cb1 ("target/i386: drop AMD machine check bits from Intel CPUID")
Signed-off-by: Xiong Zhang <xiong.y.zhang@linux.intel.com>
Link: https://lore.kernel.org/r/20240730082927.250180-1-xiong.y.zhang@linux.intel.com
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
target/i386/cpu.c

index 4688d140c2d92f6b5b2f2e0f5a935ca59e8969ca..ef06da54c637a0dbdd39652f1fcb97572f29b2b6 100644 (file)
@@ -6039,7 +6039,7 @@ uint64_t x86_cpu_get_supported_feature_word(X86CPU *cpu, FeatureWord w)
 {
     FeatureWordInfo *wi = &feature_word_info[w];
     uint64_t r = 0;
-    uint32_t unavail = 0;
+    uint64_t unavail = 0;
 
     if (kvm_enabled()) {
         switch (wi->type) {