]> www.infradead.org Git - users/hch/blktests.git/commitdiff
nvme/018: Reword misleading error message
authorDaniel Wagner <dwagner@suse.de>
Mon, 3 Feb 2020 16:40:49 +0000 (17:40 +0100)
committerOmar Sandoval <osandov@fb.com>
Mon, 3 Feb 2020 21:39:03 +0000 (13:39 -0800)
'nvme read' is expected to fail, though the error message "ERROR:
Successfully..." is misleading. Reword the error text to clarify the
real intent of the test and what failed.

Reported-by: Logan Gunthorpe <logang@deltatee.com>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: Daniel Wagner <dwagner@suse.de>
tests/nvme/018

index d0f15db23538e0d05d8f39b1cee69b5c28d8da18..67d89a6f0b24a19b1f87fc168fc2db3a2b0402d4 100755 (executable)
@@ -3,7 +3,7 @@
 # Copyright (C) 2018 Sagi Grimberg
 #
 # Test NVMe out of range access on a file backend. Regression test for commit
-# 9c891c139894 ("nvmet: check fileio lba range access boundaries").
+# 9c891c139894 ("nvmet: check fileio LBA range access boundaries").
 
 . tests/nvme/rc
 
@@ -44,7 +44,7 @@ test() {
        bs="$(blockdev --getbsz "/dev/${nvmedev}n1")"
 
        nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs" &>"$FULL" \
-               && echo "ERROR: Successfully read out of device lba range"
+               && echo "ERROR: nvme read for out of range LBA was not rejected"
 
        nvme disconnect -n "${subsys_name}"