]> www.infradead.org Git - users/hch/misc.git/commitdiff
stmmac: intel: Fix warning message for return value in intel_tsn_lane_is_available()
authorChoong Yong Liang <yong.liang.choong@linux.intel.com>
Mon, 10 Mar 2025 05:08:35 +0000 (13:08 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Mon, 17 Mar 2025 20:09:22 +0000 (21:09 +0100)
Fix the warning "warn: missing error code? 'ret'" in the
intel_tsn_lane_is_available() function.

The function now returns 0 to indicate that a TSN lane was found and
returns -EINVAL when it is not found.

Fixes: a42f6b3f1cc1 ("net: stmmac: configure SerDes according to the interface mode")
Signed-off-by: Choong Yong Liang <yong.liang.choong@linux.intel.com>
Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250310050835.808870-1-yong.liang.choong@linux.intel.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c

index 9c8de47ee149f18c945fb5da1f591c46b6f0f23d..5910571a954f9e38cc273bbfffd7cf8802dd1b6a 100644 (file)
@@ -494,10 +494,10 @@ static int intel_tsn_lane_is_available(struct net_device *ndev,
                        if ((rbuf.buf[0] >>
                                (4 * (intel_priv->tsn_lane_regs[j] % 8)) &
                                        B_PCH_FIA_PCR_L0O) == 0xB)
-                               return ret;
+                               return 0;
        }
 
-       return ret;
+       return -EINVAL;
 }
 
 static int intel_set_reg_access(const struct pmc_serdes_regs *regs, int max_regs)