]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
arm64: dts: qcom: sm8650: Add missing properties for cryptobam
authorStephan Gerhold <stephan.gerhold@linaro.org>
Wed, 12 Feb 2025 17:03:50 +0000 (18:03 +0100)
committerBjorn Andersson <andersson@kernel.org>
Thu, 13 Mar 2025 21:30:21 +0000 (16:30 -0500)
num-channels and qcom,num-ees are required for BAM nodes without clock,
because the driver cannot ensure the hardware is powered on when trying to
obtain the information from the hardware registers. Specifying the node
without these properties is unsafe and has caused early boot crashes for
other SoCs before [1, 2].

Add the missing information from the hardware registers to ensure the
driver can probe successfully without causing crashes.

[1]: https://lore.kernel.org/r/CY01EKQVWE36.B9X5TDXAREPF@fairphone.com/
[2]: https://lore.kernel.org/r/20230626145959.646747-1-krzysztof.kozlowski@linaro.org/

Cc: stable@vger.kernel.org
Fixes: 10e024671295 ("arm64: dts: qcom: sm8650: add interconnect dependent device nodes")
Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
Link: https://lore.kernel.org/r/20250212-bam-dma-fixes-v1-4-f560889e65d8@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
arch/arm64/boot/dts/qcom/sm8650.dtsi

index d5037cc306c25fc0eeede9c33c2b4d561631867b..8c551e2f58c62b06e9c2892930c6be3576370adf 100644 (file)
                                 <&apps_smmu 0x481 0>;
 
                        qcom,ee = <0>;
+                       qcom,num-ees = <4>;
+                       num-channels = <20>;
                        qcom,controlled-remotely;
                };