]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
drm/amd/display: add NULL pointer check
authorCharlene Liu <charlene.liu@amd.com>
Sat, 20 May 2023 00:43:30 +0000 (20:43 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 9 Jun 2023 16:49:56 +0000 (12:49 -0400)
[why]
check dmub_Srv exist or not before accessing dmub.

Acked-by: Stylon Wang <stylon.wang@amd.com>
Signed-off-by: Charlene Liu <charlene.liu@amd.com>
Reviewed-by: Zhan Liu <Zhan.Liu@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/core/dc_stream.c

index 0d3ec50b13851398631fb1152759045bb20ade1f..6e11d2b701f82fc5e437eda80dbed72d6d21a998 100644 (file)
@@ -276,8 +276,8 @@ static void program_cursor_attributes(
                }
 
                dc->hwss.set_cursor_attribute(pipe_ctx);
-
-               dc_send_update_cursor_info_to_dmu(pipe_ctx, i);
+               if (dc->ctx->dmub_srv)
+                       dc_send_update_cursor_info_to_dmu(pipe_ctx, i);
                if (dc->hwss.set_cursor_sdr_white_level)
                        dc->hwss.set_cursor_sdr_white_level(pipe_ctx);
        }
@@ -396,8 +396,8 @@ static void program_cursor_position(
                }
 
                dc->hwss.set_cursor_position(pipe_ctx);
-
-               dc_send_update_cursor_info_to_dmu(pipe_ctx, i);
+               if (dc->ctx->dmub_srv)
+                       dc_send_update_cursor_info_to_dmu(pipe_ctx, i);
        }
 
        if (pipe_to_program)