media: tegra-cec: Handle errors of clk_prepare_enable()

tegra_cec_probe() and tegra_cec_resume() ignored possible errors of
clk_prepare_enable(). The patch fixes this.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

diff --git a/drivers/media/cec/platform/tegra/tegra_cec.c b/drivers/media/cec/platform/tegra/tegra_cec.c
index 1ac0c70a5981829afe733ccb4a5066ae3e52625c..5e907395ca2e5283bd8ebdf06b8dce85adc7b60f 100644 (file)
--- a/drivers/media/cec/platform/tegra/tegra_cec.c
+++ b/drivers/media/cec/platform/tegra/tegra_cec.c
@@ -366,7 +366,11 @@ static int tegra_cec_probe(struct platform_device *pdev)
                return -ENOENT;
        }
 
-       clk_prepare_enable(cec->clk);
+       ret = clk_prepare_enable(cec->clk);
+       if (ret) {
+               dev_err(&pdev->dev, "Unable to prepare clock for CEC\n");
+               return ret;
+       }
 
        /* set context info. */
        cec->dev = &pdev->dev;
@@ -446,9 +450,7 @@ static int tegra_cec_resume(struct platform_device *pdev)
 
        dev_notice(&pdev->dev, "Resuming\n");
 
-       clk_prepare_enable(cec->clk);
-
-       return 0;
+       return clk_prepare_enable(cec->clk);
 }
 #endif