]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
nfs: Drop pointless check from nfs_commit_release_pages()
authorJan Kara <jack@suse.cz>
Mon, 1 Jul 2024 10:50:46 +0000 (12:50 +0200)
committerAnna Schumaker <Anna.Schumaker@Netapp.com>
Mon, 8 Jul 2024 17:47:27 +0000 (13:47 -0400)
nfss->writeback is updated only when we are ending page writeback and at
that moment we also clear nfss->write_congested. So there's no point in
rechecking congestion state in nfs_commit_release_pages(). Drop the
pointless check.

Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
fs/nfs/write.c

index f5414c96381ac87abb9286dbc4dc0b7f7fbd43e4..4321cdc581bb5fc346cf0b8ae4f27a6f34dbefea 100644 (file)
@@ -1846,7 +1846,6 @@ static void nfs_commit_release_pages(struct nfs_commit_data *data)
        struct nfs_page *req;
        int status = data->task.tk_status;
        struct nfs_commit_info cinfo;
-       struct nfs_server *nfss;
        struct folio *folio;
 
        while (!list_empty(&data->pages)) {
@@ -1889,9 +1888,6 @@ static void nfs_commit_release_pages(struct nfs_commit_data *data)
                /* Latency breaker */
                cond_resched();
        }
-       nfss = NFS_SERVER(data->inode);
-       if (atomic_long_read(&nfss->writeback) < NFS_CONGESTION_OFF_THRESH)
-               nfss->write_congested = 0;
 
        nfs_init_cinfo(&cinfo, data->inode, data->dreq);
        nfs_commit_end(cinfo.mds);