clk: berlin: Add of_node_put() for of_get_parent()

In berlin2_clock_setup() and berlin2q_clock_setup(), we need to
call of_node_put() for the reference returned by of_get_parent()
which has increased the refcount. We should call *_put() in fail
path or when it is not used anymore.

Fixes: 26b3b6b959b2 ("clk: berlin: prepare simple-mfd conversion")
Signed-off-by: Liang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220708084900.311684-1-windhl@126.com
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

diff --git a/drivers/clk/berlin/bg2.c b/drivers/clk/berlin/bg2.c
index bccdfa00fd37394aa62538356783ccd3a9eef8e3..67a9edbba29c448bbd9f58e3e06f095788d1168e 100644 (file)
--- a/drivers/clk/berlin/bg2.c
+++ b/drivers/clk/berlin/bg2.c
@@ -500,12 +500,15 @@ static void __init berlin2_clock_setup(struct device_node *np)
        int n, ret;
 
        clk_data = kzalloc(struct_size(clk_data, hws, MAX_CLKS), GFP_KERNEL);
-       if (!clk_data)
+       if (!clk_data) {
+               of_node_put(parent_np);
                return;
+       }
        clk_data->num = MAX_CLKS;
        hws = clk_data->hws;
 
        gbase = of_iomap(parent_np, 0);
+       of_node_put(parent_np);
        if (!gbase)
                return;
 

diff --git a/drivers/clk/berlin/bg2q.c b/drivers/clk/berlin/bg2q.c
index e9518d35f262e171cb1233707579f8b8102a4023..dd2784bb75b649c2f5eb072759ff4fee6a4cc47a 100644 (file)
--- a/drivers/clk/berlin/bg2q.c
+++ b/drivers/clk/berlin/bg2q.c
@@ -286,19 +286,23 @@ static void __init berlin2q_clock_setup(struct device_node *np)
        int n, ret;
 
        clk_data = kzalloc(struct_size(clk_data, hws, MAX_CLKS), GFP_KERNEL);
-       if (!clk_data)
+       if (!clk_data) {
+               of_node_put(parent_np);
                return;
+       }
        clk_data->num = MAX_CLKS;
        hws = clk_data->hws;
 
        gbase = of_iomap(parent_np, 0);
        if (!gbase) {
+               of_node_put(parent_np);
                pr_err("%pOF: Unable to map global base\n", np);
                return;
        }
 
        /* BG2Q CPU PLL is not part of global registers */
        cpupll_base = of_iomap(parent_np, 1);
+       of_node_put(parent_np);
        if (!cpupll_base) {
                pr_err("%pOF: Unable to map cpupll base\n", np);
                iounmap(gbase);