platform: Add platform_find_device_by_driver() helper

Provide a helper to lookup platform devices by matching device
driver in order to avoid drivers trying to use platform bus
internals.

Cc: Eric Anholt <eric@anholt.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Heiko Stübner" <heiko@sntech.de>
Cc: Inki Dae <inki.dae@samsung.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Sandy Huang <hjc@rock-chips.com>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
Tested-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/20190723221838.12024-8-suzuki.poulose@arm.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index 506a0175a5a781cf297cc0153038dc4aa9b48d86..a174ce5ea17ccbd9df1ad66da3cd5082ebb2fc3c 100644 (file)
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -1197,6 +1197,20 @@ struct bus_type platform_bus_type = {
 };
 EXPORT_SYMBOL_GPL(platform_bus_type);
 
+/**
+ * platform_find_device_by_driver - Find a platform device with a given
+ * driver.
+ * @start: The device to start the search from.
+ * @drv: The device driver to look for.
+ */
+struct device *platform_find_device_by_driver(struct device *start,
+                                             const struct device_driver *drv)
+{
+       return bus_find_device(&platform_bus_type, start, drv,
+                              (void *)platform_match);
+}
+EXPORT_SYMBOL_GPL(platform_find_device_by_driver);
+
 int __init platform_bus_init(void)
 {
        int error;

diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
index 58baf49d992625ef75628392195f3769f32ded02..badab94be2d6eaac5bd2b32d5d668df6caf8b9bb 100644 (file)
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
@@ -242,9 +242,7 @@ static struct component_match *exynos_drm_match_add(struct device *dev)
                if (!info->driver || !(info->flags & DRM_COMPONENT_DRIVER))
                        continue;
 
-               while ((d = bus_find_device(&platform_bus_type, p,
-                                           &info->driver->driver,
-                                           (void *)platform_bus_type.match))) {
+               while ((d = platform_find_device_by_driver(p, &info->driver->driver))) {
                        put_device(p);
 
                        if (!(info->flags & DRM_FIMC_DEVICE) ||
@@ -412,9 +410,8 @@ static void exynos_drm_unregister_devices(void)
                if (!info->driver || !(info->flags & DRM_VIRTUAL_DEVICE))
                        continue;
 
-               while ((dev = bus_find_device(&platform_bus_type, NULL,
-                                           &info->driver->driver,
-                                           (void *)platform_bus_type.match))) {
+               while ((dev = platform_find_device_by_driver(NULL,
+                                               &info->driver->driver))) {
                        put_device(dev);
                        platform_device_unregister(to_platform_device(dev));
                }

diff --git a/drivers/gpu/drm/mcde/mcde_drv.c b/drivers/gpu/drm/mcde/mcde_drv.c
index baf63fb6850a418c5c4b245fc09bf93fff0ef894..c07abf9e201c13f9d0cbde32cac402997e03e722 100644 (file)
--- a/drivers/gpu/drm/mcde/mcde_drv.c
+++ b/drivers/gpu/drm/mcde/mcde_drv.c
@@ -477,8 +477,7 @@ static int mcde_probe(struct platform_device *pdev)
                struct device_driver *drv = &mcde_component_drivers[i]->driver;
                struct device *p = NULL, *d;
 
-               while ((d = bus_find_device(&platform_bus_type, p, drv,
-                                           (void *)platform_bus_type.match))) {
+               while ((d = platform_find_device_by_driver(p, drv))) {
                        put_device(p);
                        component_match_add(dev, &match, mcde_compare_dev, d);
                        p = d;

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
index 53d2c5bd61dcd1545d87153d1f1e9f92429ddf1d..38dc263769615c70e2b56f21fc885e6ca8a75c8b 100644 (file)
--- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
@@ -330,8 +330,7 @@ static struct component_match *rockchip_drm_match_add(struct device *dev)
                struct device *p = NULL, *d;
 
                do {
-                       d = bus_find_device(&platform_bus_type, p, &drv->driver,
-                                           (void *)platform_bus_type.match);
+                       d = platform_find_device_by_driver(p, &drv->driver);
                        put_device(p);
                        p = d;
 

diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
index bf11930e40e19ea3cd0eb2e65017d8530a64ae0b..1551c8253bec0e62b5f0ca7c16128f8ac93c58fc 100644 (file)
--- a/drivers/gpu/drm/vc4/vc4_drv.c
+++ b/drivers/gpu/drm/vc4/vc4_drv.c
@@ -237,8 +237,7 @@ static void vc4_match_add_drivers(struct device *dev,
                struct device_driver *drv = &drivers[i]->driver;
                struct device *p = NULL, *d;
 
-               while ((d = bus_find_device(&platform_bus_type, p, drv,
-                                           (void *)platform_bus_type.match))) {
+               while ((d = platform_find_device_by_driver(p, drv))) {
                        put_device(p);
                        component_match_add(dev, match, compare_dev, d);
                        p = d;

diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h
index 9bc36b589827fe41e47c975044622108f127bff5..37e15a935a42f4fb2bc2575ae2451a3026d24e41 100644 (file)
--- a/include/linux/platform_device.h
+++ b/include/linux/platform_device.h
@@ -51,6 +51,9 @@ extern struct device platform_bus;
 extern void arch_setup_pdev_archdata(struct platform_device *);
 extern struct resource *platform_get_resource(struct platform_device *,
                                              unsigned int, unsigned int);
+extern struct device *
+platform_find_device_by_driver(struct device *start,
+                              const struct device_driver *drv);
 extern void __iomem *
 devm_platform_ioremap_resource(struct platform_device *pdev,
                               unsigned int index);