ubi-utils: ubirsvol: Fix integer overflow in ubirsvol.c

Report of the static analyzer:
The value of an arithmetic expression 'vol_info.leb_size * args.lebs' is a subject to overflow because its operands are not cast to a larger data type before performing arithmetic

Corrections explained:
The fix ensures values ​​are checked before multiplication.
Added casting vol_info.leb_size to long long

Triggers found by static analyzer Svace.

Signed-off-by: Anton Moryakov <ant.v.moryakov@gmail.com>
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>

diff --git a/ubi-utils/ubirsvol.c b/ubi-utils/ubirsvol.c
index 0854abc53947dde9d26f5ee95f151b2375bc70ae..73d2f68710025e15732441f6076c981cad6d7703 100644 (file)
--- a/ubi-utils/ubirsvol.c
+++ b/ubi-utils/ubirsvol.c
@@ -231,7 +231,7 @@ int main(int argc, char * const argv[])
        }
 
        if (args.lebs != -1)
-               args.bytes = vol_info.leb_size * args.lebs;
+               args.bytes = (long long)vol_info.leb_size * args.lebs;
 
        err = ubi_rsvol(libubi, args.node, args.vol_id, args.bytes);
        if (err) {