]> www.infradead.org Git - users/hch/misc.git/commitdiff
mtd: nand: Drop explicit test for built-in CONFIG_SPI_QPIC_SNAND
authorGeert Uytterhoeven <geert+renesas@glider.be>
Fri, 28 Mar 2025 08:24:01 +0000 (09:24 +0100)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Mon, 7 Apr 2025 07:01:58 +0000 (09:01 +0200)
If CONFIG_SPI_QPIC_SNAND=m, but CONFIG_MTD_NAND_QCOM=n:

    ERROR: modpost: "qcom_nandc_unalloc" [drivers/spi/spi-qpic-snand.ko] undefined!
    ...

Fix this by dropping the explicit test for a built-in
CONFIG_SPI_QPIC_SNAND completely.  Kbuild handles multiple and mixed
obj-y/obj-m rules for the same object file fine.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202503280759.XhwLcV7m-lkp@intel.com/
Fixes: 7304d1909080ef0c ("spi: spi-qpic: add driver for QCOM SPI NAND flash Interface")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
drivers/mtd/nand/Makefile

index db516a45f0c52635dd21b04cbed77c49b00c359d..44913ff1bf12cc2442fa687bbf80a4052ed8679d 100644 (file)
@@ -3,11 +3,8 @@
 nandcore-objs := core.o bbt.o
 obj-$(CONFIG_MTD_NAND_CORE) += nandcore.o
 obj-$(CONFIG_MTD_NAND_ECC_MEDIATEK) += ecc-mtk.o
-ifeq ($(CONFIG_SPI_QPIC_SNAND),y)
 obj-$(CONFIG_SPI_QPIC_SNAND) += qpic_common.o
-else
 obj-$(CONFIG_MTD_NAND_QCOM) += qpic_common.o
-endif
 obj-y  += onenand/
 obj-y  += raw/
 obj-y  += spi/