]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
xen/arm: don't ignore return errors from set_phys_to_machine
authorStefano Stabellini <stefano.stabellini@xilinx.com>
Mon, 15 Feb 2021 07:53:44 +0000 (08:53 +0100)
committerJuergen Gross <jgross@suse.com>
Mon, 15 Feb 2021 07:53:44 +0000 (08:53 +0100)
set_phys_to_machine can fail due to lack of memory, see the kzalloc call
in arch/arm/xen/p2m.c:__set_phys_to_machine_multi.

Don't ignore the potential return error in set_foreign_p2m_mapping,
returning it to the caller instead.

This is part of XSA-361.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Cc: stable@vger.kernel.org
Reviewed-by: Julien Grall <jgrall@amazon.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
arch/arm/xen/p2m.c

index e52950a43f2ed6aa52a7ce94dc1a07899c3475c7..fd6e3aafe27241ad1a2a11f72fb51adc6fd4438f 100644 (file)
@@ -95,8 +95,10 @@ int set_foreign_p2m_mapping(struct gnttab_map_grant_ref *map_ops,
        for (i = 0; i < count; i++) {
                if (map_ops[i].status)
                        continue;
-               set_phys_to_machine(map_ops[i].host_addr >> XEN_PAGE_SHIFT,
-                                   map_ops[i].dev_bus_addr >> XEN_PAGE_SHIFT);
+               if (unlikely(!set_phys_to_machine(map_ops[i].host_addr >> XEN_PAGE_SHIFT,
+                                   map_ops[i].dev_bus_addr >> XEN_PAGE_SHIFT))) {
+                       return -ENOMEM;
+               }
        }
 
        return 0;