Fix memory leak in F5 config parsing

Wouldn't this be easier in C++? Or maybe Rust?

Signed-off-by: David Woodhouse <dwmw2@infradead.org>

diff --git a/f5.c b/f5.c
index 7023d99f31c9d4366f990ccd3f069709953a2b0d..d7c0332af83410abf565779fb87d5743819f60bc 100644 (file)
--- a/f5.c
+++ b/f5.c
@@ -421,6 +421,7 @@ static int parse_options(struct openconnect_info *vpninfo, char *buf, int len,
                        }
                } else if (   (!strncmp((char *)xml_node->name, "LAN", 3) && isdigit((char)xml_node->name[3]))
                           || (!strncmp((char *)xml_node->name, "LAN6_", 5) && isdigit((char)xml_node->name[5]))) {
+                       free(s);
                        s = (char *)xmlNodeGetContent(xml_node);
                        if (s && *s) {
                                char *word, *next;