]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
PCI: iproc: Fix return value of iproc_msi_irq_domain_alloc()
authorPali Rohár <pali@kernel.org>
Wed, 3 Mar 2021 14:22:02 +0000 (15:22 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 May 2021 08:08:25 +0000 (10:08 +0200)
[ Upstream commit 1e83130f01b04c16579ed5a5e03d729bcffc4c5d ]

IRQ domain alloc function should return zero on success. Non-zero value
indicates failure.

Link: https://lore.kernel.org/r/20210303142202.25780-1-pali@kernel.org
Fixes: fc54bae28818 ("PCI: iproc: Allow allocation of multiple MSIs")
Signed-off-by: Pali Rohár <pali@kernel.org>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
Acked-by: Ray Jui <ray.jui@broadcom.com>
Acked-by: Marc Zyngier <maz@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pci/controller/pcie-iproc-msi.c

index a1298f6784ac9f97644749463e85c8825a2309a8..f40d17b285c5e19f0ccdf5126b64ee7d395e9136 100644 (file)
@@ -271,7 +271,7 @@ static int iproc_msi_irq_domain_alloc(struct irq_domain *domain,
                                    NULL, NULL);
        }
 
-       return hwirq;
+       return 0;
 }
 
 static void iproc_msi_irq_domain_free(struct irq_domain *domain,