]> www.infradead.org Git - nvme.git/commitdiff
block: Document the role of the two attribute groups
authorBart Van Assche <bvanassche@acm.org>
Tue, 28 Nov 2023 19:40:19 +0000 (11:40 -0800)
committerJens Axboe <axboe@kernel.dk>
Wed, 29 Nov 2023 17:18:38 +0000 (10:18 -0700)
It is nontrivial to derive the role of the two attribute groups in source
file block/blk-sysfs.c. Hence add a comment that explains their roles. See
also commit 6d85ebf95c44 ("blk-sysfs: add a new attr_group for blk_mq").

Cc: Christoph Hellwig <hch@lst.de>
Cc: Yu Kuai <yukuai3@huawei.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20231128194019.72762-1-bvanassche@acm.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-sysfs.c

index 63e4812623361ddde759809c4e04b715aa871e43..0b2d0476632407a97525cdb538c6a94803095c7f 100644 (file)
@@ -615,6 +615,7 @@ static ssize_t queue_wb_lat_store(struct request_queue *q, const char *page,
 QUEUE_RW_ENTRY(queue_wb_lat, "wbt_lat_usec");
 #endif
 
+/* Common attributes for bio-based and request-based queues. */
 static struct attribute *queue_attrs[] = {
        &queue_ra_entry.attr,
        &queue_max_hw_sectors_entry.attr,
@@ -659,6 +660,7 @@ static struct attribute *queue_attrs[] = {
        NULL,
 };
 
+/* Request-based queue attributes that are not relevant for bio-based queues. */
 static struct attribute *blk_mq_queue_attrs[] = {
        &queue_requests_entry.attr,
        &elv_iosched_entry.attr,