]> www.infradead.org Git - users/hch/dma-mapping.git/commitdiff
pinctrl: stmfx: stmfx_pinconf_set doesn't require to get direction anymore
authorAmelie Delaunay <amelie.delaunay@st.com>
Wed, 22 Apr 2020 07:25:13 +0000 (09:25 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 28 Apr 2020 12:49:11 +0000 (14:49 +0200)
Pin direction is not used to set pin configuration.

Fixes: a502b343ebd0 ("pinctrl: stmfx: update pinconf settings")
Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
Link: https://lore.kernel.org/r/20200422072513.8352-1-amelie.delaunay@st.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-stmfx.c

index 60100b45f5e5ed8377df9eaaad3785be36901328..1aae803c12cd133951a2bf69960c969cab1a8b38 100644 (file)
@@ -288,7 +288,7 @@ static int stmfx_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
        struct pinctrl_gpio_range *range;
        enum pin_config_param param;
        u32 arg;
-       int dir, i, ret;
+       int i, ret;
 
        range = pinctrl_find_gpio_range_from_pin_nolock(pctldev, pin);
        if (!range) {
@@ -296,10 +296,6 @@ static int stmfx_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
                return -EINVAL;
        }
 
-       dir = stmfx_gpio_get_direction(&pctl->gpio_chip, pin);
-       if (dir < 0)
-               return dir;
-
        for (i = 0; i < num_configs; i++) {
                param = pinconf_to_config_param(configs[i]);
                arg = pinconf_to_config_argument(configs[i]);