staging: wilc1000: fix freeing of ERR_PTR

If memdup_user() fails then it will return the error code in ERR_PTR. We
were checking it with IS_ERR but then again trying to free it on the
error path.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
index c90c45907422db74031463cf2e42d551dd5c8424..020ed038130fa936af227a8f228e17b182aab405 100644 (file)
--- a/drivers/staging/wilc1000/linux_wlan.c
+++ b/drivers/staging/wilc1000/linux_wlan.c
@@ -2116,10 +2116,8 @@ int mac_ioctl(struct net_device *ndev, struct ifreq *req, int cmd)
                if (size && wrq->u.data.pointer) {
 
                        buff = memdup_user(wrq->u.data.pointer, wrq->u.data.length);
-                       if (IS_ERR(buff)) {
-                               s32Error = PTR_ERR(buff);
-                               goto done;
-                       }
+                       if (IS_ERR(buff))
+                               return PTR_ERR(buff);
 
                        if (strncasecmp(buff, "RSSI", length) == 0) {