drm/i915: Handle joined pipes inside hsw_crtc_enable()

Handle only bigjoiner masters in skl_commit_modeset_enables/disables,
slave crtcs should be handled by master hooks. Same for encoders.
That way we can also remove a bunch of checks like intel_crtc_is_bigjoiner_slave.

v2: - Moved skl_pfit_enable, intel_dsc_enable, intel_crtc_vblank_on to intel_enable_ddi,
      so that it is now finally symmetrical with the disable case, because currently
      for some weird reason we are calling those from skl_commit_modeset_enables, while
      for the disable case those are called from the ddi disable hooks.
v3: - Create intel_ddi_enable_hdmi_or_sst symmetrical to
      intel_ddi_post_disable_hdmi_or_sst and move it also under non-mst check.
v4: - Fix intel_enable_ddi sequence
    - Call intel_crtc_update_active_timings for slave pipes as well
[v5: vsyrjala: Use the name 'pipe_crtc' for the per-pipe crtc pointer
               Use consistent style and naming
	       Protect macro arguments properly
               Drop superfluous changes to the modeset sequence,
	       this now follows the old non-joiner sequence 100%
	       apart from just looping in places]

Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Tested-by: Vidya Srinivas <vidya.srinivas@intel.com>
Reviewed-by: Manasi Navare <navaremanasi@chromium.org> #v4?
Co-developed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240409163502.29633-5-ville.syrjala@linux.intel.com

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index deaed9ff3f95f4f061915b10004da1f680ed95ca..3255d4e375af7ee90aa2b9f36e0dcf2ea19dea90 100644 (file)
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -3363,10 +3363,10 @@ static void intel_enable_ddi(struct intel_atomic_state *state,
                             const struct intel_crtc_state *crtc_state,
                             const struct drm_connector_state *conn_state)
 {
-       drm_WARN_ON(state->base.dev, crtc_state->has_pch_encoder);
+       struct drm_i915_private *i915 = to_i915(encoder->base.dev);
+       struct intel_crtc *pipe_crtc;
 
-       if (!intel_crtc_is_bigjoiner_slave(crtc_state))
-               intel_ddi_enable_transcoder_func(encoder, crtc_state);
+       intel_ddi_enable_transcoder_func(encoder, crtc_state);
 
        /* Enable/Disable DP2.0 SDP split config before transcoder */
        intel_audio_sdp_split_update(crtc_state);
@@ -3375,7 +3375,13 @@ static void intel_enable_ddi(struct intel_atomic_state *state,
 
        intel_ddi_wait_for_fec_status(encoder, crtc_state, true);
 
-       intel_crtc_vblank_on(crtc_state);
+       for_each_intel_crtc_in_pipe_mask_reverse(&i915->drm, pipe_crtc,
+                                                intel_crtc_joined_pipe_mask(crtc_state)) {
+               const struct intel_crtc_state *pipe_crtc_state =
+                       intel_atomic_get_new_crtc_state(state, pipe_crtc);
+
+               intel_crtc_vblank_on(pipe_crtc_state);
+       }
 
        if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI))
                intel_enable_ddi_hdmi(state, encoder, crtc_state, conn_state);

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 303625344d547b71ab4ba113f72a9d63b98341de..a92b67adee9c1c59173a8749bffa5191bdb2d3c3 100644 (file)
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -1620,24 +1620,6 @@ static void hsw_set_frame_start_delay(const struct intel_crtc_state *crtc_state)
                     HSW_FRAME_START_DELAY(crtc_state->framestart_delay - 1));
 }
 
-static void icl_ddi_bigjoiner_pre_enable(struct intel_atomic_state *state,
-                                        const struct intel_crtc_state *crtc_state)
-{
-       struct intel_crtc *master_crtc = intel_master_crtc(crtc_state);
-
-       /*
-        * Enable sequence steps 1-7 on bigjoiner master
-        */
-       if (intel_crtc_is_bigjoiner_slave(crtc_state))
-               intel_encoders_pre_pll_enable(state, master_crtc);
-
-       if (crtc_state->shared_dpll)
-               intel_enable_shared_dpll(crtc_state);
-
-       if (intel_crtc_is_bigjoiner_slave(crtc_state))
-               intel_encoders_pre_enable(state, master_crtc);
-}
-
 static void hsw_configure_cpu_transcoder(const struct intel_crtc_state *crtc_state)
 {
        struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
@@ -1674,85 +1656,106 @@ static void hsw_crtc_enable(struct intel_atomic_state *state,
                intel_atomic_get_new_crtc_state(state, crtc);
        struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
        enum transcoder cpu_transcoder = new_crtc_state->cpu_transcoder;
-       enum pipe hsw_workaround_pipe;
+       struct intel_crtc *pipe_crtc;
 
        if (drm_WARN_ON(&dev_priv->drm, crtc->active))
                return;
 
-       intel_dmc_enable_pipe(dev_priv, crtc->pipe);
+       for_each_intel_crtc_in_pipe_mask_reverse(&dev_priv->drm, pipe_crtc,
+                                                intel_crtc_joined_pipe_mask(new_crtc_state))
+               intel_dmc_enable_pipe(dev_priv, pipe_crtc->pipe);
 
-       if (!new_crtc_state->bigjoiner_pipes) {
-               intel_encoders_pre_pll_enable(state, crtc);
+       intel_encoders_pre_pll_enable(state, crtc);
 
-               if (new_crtc_state->shared_dpll)
-                       intel_enable_shared_dpll(new_crtc_state);
+       for_each_intel_crtc_in_pipe_mask_reverse(&dev_priv->drm, pipe_crtc,
+                                                intel_crtc_joined_pipe_mask(new_crtc_state)) {
+               const struct intel_crtc_state *pipe_crtc_state =
+                       intel_atomic_get_new_crtc_state(state, pipe_crtc);
 
-               intel_encoders_pre_enable(state, crtc);
-       } else {
-               icl_ddi_bigjoiner_pre_enable(state, new_crtc_state);
+               if (pipe_crtc_state->shared_dpll)
+                       intel_enable_shared_dpll(pipe_crtc_state);
        }
 
-       intel_dsc_enable(new_crtc_state);
+       intel_encoders_pre_enable(state, crtc);
 
-       if (DISPLAY_VER(dev_priv) >= 13)
-               intel_uncompressed_joiner_enable(new_crtc_state);
+       for_each_intel_crtc_in_pipe_mask_reverse(&dev_priv->drm, pipe_crtc,
+                                                intel_crtc_joined_pipe_mask(new_crtc_state)) {
+               const struct intel_crtc_state *pipe_crtc_state =
+                       intel_atomic_get_new_crtc_state(state, pipe_crtc);
 
-       intel_set_pipe_src_size(new_crtc_state);
-       if (DISPLAY_VER(dev_priv) >= 9 || IS_BROADWELL(dev_priv))
-               bdw_set_pipe_misc(new_crtc_state);
+               intel_dsc_enable(pipe_crtc_state);
 
-       if (!intel_crtc_is_bigjoiner_slave(new_crtc_state) &&
-           !transcoder_is_dsi(cpu_transcoder))
+               if (DISPLAY_VER(dev_priv) >= 13)
+                       intel_uncompressed_joiner_enable(pipe_crtc_state);
+
+               intel_set_pipe_src_size(pipe_crtc_state);
+
+               if (DISPLAY_VER(dev_priv) >= 9 || IS_BROADWELL(dev_priv))
+                       bdw_set_pipe_misc(pipe_crtc_state);
+       }
+
+       if (!transcoder_is_dsi(cpu_transcoder))
                hsw_configure_cpu_transcoder(new_crtc_state);
 
-       crtc->active = true;
+       for_each_intel_crtc_in_pipe_mask_reverse(&dev_priv->drm, pipe_crtc,
+                                                intel_crtc_joined_pipe_mask(new_crtc_state)) {
+               const struct intel_crtc_state *pipe_crtc_state =
+                       intel_atomic_get_new_crtc_state(state, pipe_crtc);
 
-       if (glk_need_scaler_clock_gating_wa(new_crtc_state))
-               glk_pipe_scaler_clock_gating_wa(crtc, true);
+               pipe_crtc->active = true;
 
-       if (DISPLAY_VER(dev_priv) >= 9)
-               skl_pfit_enable(new_crtc_state);
-       else
-               ilk_pfit_enable(new_crtc_state);
+               if (glk_need_scaler_clock_gating_wa(pipe_crtc_state))
+                       glk_pipe_scaler_clock_gating_wa(pipe_crtc, true);
 
-       /*
-        * On ILK+ LUT must be loaded before the pipe is running but with
-        * clocks enabled
-        */
-       intel_color_load_luts(new_crtc_state);
-       intel_color_commit_noarm(new_crtc_state);
-       intel_color_commit_arm(new_crtc_state);
-       /* update DSPCNTR to configure gamma/csc for pipe bottom color */
-       if (DISPLAY_VER(dev_priv) < 9)
-               intel_disable_primary_plane(new_crtc_state);
+               if (DISPLAY_VER(dev_priv) >= 9)
+                       skl_pfit_enable(pipe_crtc_state);
+               else
+                       ilk_pfit_enable(pipe_crtc_state);
 
-       hsw_set_linetime_wm(new_crtc_state);
+               /*
+                * On ILK+ LUT must be loaded before the pipe is running but with
+                * clocks enabled
+                */
+               intel_color_load_luts(pipe_crtc_state);
+               intel_color_commit_noarm(pipe_crtc_state);
+               intel_color_commit_arm(pipe_crtc_state);
+               /* update DSPCNTR to configure gamma/csc for pipe bottom color */
+               if (DISPLAY_VER(dev_priv) < 9)
+                       intel_disable_primary_plane(pipe_crtc_state);
 
-       if (DISPLAY_VER(dev_priv) >= 11)
-               icl_set_pipe_chicken(new_crtc_state);
+               hsw_set_linetime_wm(pipe_crtc_state);
 
-       intel_initial_watermarks(state, crtc);
+               if (DISPLAY_VER(dev_priv) >= 11)
+                       icl_set_pipe_chicken(pipe_crtc_state);
 
-       if (intel_crtc_is_bigjoiner_slave(new_crtc_state))
-               intel_crtc_vblank_on(new_crtc_state);
+               intel_initial_watermarks(state, pipe_crtc);
+       }
 
        intel_encoders_enable(state, crtc);
 
-       if (glk_need_scaler_clock_gating_wa(new_crtc_state)) {
-               intel_crtc_wait_for_next_vblank(crtc);
-               glk_pipe_scaler_clock_gating_wa(crtc, false);
-       }
+       for_each_intel_crtc_in_pipe_mask_reverse(&dev_priv->drm, pipe_crtc,
+                                                intel_crtc_joined_pipe_mask(new_crtc_state)) {
+               const struct intel_crtc_state *pipe_crtc_state =
+                       intel_atomic_get_new_crtc_state(state, pipe_crtc);
+               enum pipe hsw_workaround_pipe;
 
-       /* If we change the relative order between pipe/planes enabling, we need
-        * to change the workaround. */
-       hsw_workaround_pipe = new_crtc_state->hsw_workaround_pipe;
-       if (IS_HASWELL(dev_priv) && hsw_workaround_pipe != INVALID_PIPE) {
-               struct intel_crtc *wa_crtc;
+               if (glk_need_scaler_clock_gating_wa(pipe_crtc_state)) {
+                       intel_crtc_wait_for_next_vblank(pipe_crtc);
+                       glk_pipe_scaler_clock_gating_wa(pipe_crtc, false);
+               }
 
-               wa_crtc = intel_crtc_for_pipe(dev_priv, hsw_workaround_pipe);
+               /*
+                * If we change the relative order between pipe/planes
+                * enabling, we need to change the workaround.
+                */
+               hsw_workaround_pipe = pipe_crtc_state->hsw_workaround_pipe;
+               if (IS_HASWELL(dev_priv) && hsw_workaround_pipe != INVALID_PIPE) {
+                       struct intel_crtc *wa_crtc =
+                               intel_crtc_for_pipe(dev_priv, hsw_workaround_pipe);
 
-               intel_crtc_wait_for_next_vblank(wa_crtc);
-               intel_crtc_wait_for_next_vblank(wa_crtc);
+                       intel_crtc_wait_for_next_vblank(wa_crtc);
+                       intel_crtc_wait_for_next_vblank(wa_crtc);
+               }
        }
 }
 
@@ -6763,17 +6766,21 @@ static void intel_enable_crtc(struct intel_atomic_state *state,
        struct drm_i915_private *dev_priv = to_i915(state->base.dev);
        const struct intel_crtc_state *new_crtc_state =
                intel_atomic_get_new_crtc_state(state, crtc);
+       struct intel_crtc *pipe_crtc;
 
        if (!intel_crtc_needs_modeset(new_crtc_state))
                return;
 
-       /* VRR will be enable later, if required */
-       intel_crtc_update_active_timings(new_crtc_state, false);
+       for_each_intel_crtc_in_pipe_mask_reverse(&dev_priv->drm, pipe_crtc,
+                                                intel_crtc_joined_pipe_mask(new_crtc_state)) {
+               const struct intel_crtc_state *pipe_crtc_state =
+                       intel_atomic_get_new_crtc_state(state, pipe_crtc);
 
-       dev_priv->display.funcs.display->crtc_enable(state, crtc);
+               /* VRR will be enable later, if required */
+               intel_crtc_update_active_timings(pipe_crtc_state, false);
+       }
 
-       if (intel_crtc_is_bigjoiner_slave(new_crtc_state))
-               return;
+       dev_priv->display.funcs.display->crtc_enable(state, crtc);
 
        /* vblanks work again, re-enable pipe CRC. */
        intel_crtc_enable_pipe_crc(crtc);
@@ -7079,12 +7086,14 @@ static void skl_commit_modeset_enables(struct intel_atomic_state *state)
                if ((modeset_pipes & BIT(pipe)) == 0)
                        continue;
 
+               if (intel_crtc_is_bigjoiner_slave(new_crtc_state))
+                       continue;
+
                if (intel_dp_mst_is_slave_trans(new_crtc_state) ||
-                   is_trans_port_sync_master(new_crtc_state) ||
-                   intel_crtc_is_bigjoiner_master(new_crtc_state))
+                   is_trans_port_sync_master(new_crtc_state))
                        continue;
 
-               modeset_pipes &= ~BIT(pipe);
+               modeset_pipes &= ~intel_crtc_joined_pipe_mask(new_crtc_state);
 
                intel_enable_crtc(state, crtc);
        }
@@ -7099,7 +7108,10 @@ static void skl_commit_modeset_enables(struct intel_atomic_state *state)
                if ((modeset_pipes & BIT(pipe)) == 0)
                        continue;
 
-               modeset_pipes &= ~BIT(pipe);
+               if (intel_crtc_is_bigjoiner_slave(new_crtc_state))
+                       continue;
+
+               modeset_pipes &= ~intel_crtc_joined_pipe_mask(new_crtc_state);
 
                intel_enable_crtc(state, crtc);
        }

diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
index 898b116633772a27b8540a5c0dc0b45875325d26..56d1c0e3e62cd62a90085530192f6df9c493ab46 100644 (file)
--- a/drivers/gpu/drm/i915/display/intel_display.h
+++ b/drivers/gpu/drm/i915/display/intel_display.h
@@ -280,6 +280,12 @@ enum phy_fia {
                            base.head)                                  \
                for_each_if((pipe_mask) & BIT(intel_crtc->pipe))
 
+#define for_each_intel_crtc_in_pipe_mask_reverse(dev, intel_crtc, pipe_mask)   \
+       list_for_each_entry_reverse((intel_crtc),                               \
+                                   &(dev)->mode_config.crtc_list,              \
+                                   base.head)                                  \
+               for_each_if((pipe_mask) & BIT((intel_crtc)->pipe))
+
 #define for_each_intel_encoder(dev, intel_encoder)             \
        list_for_each_entry(intel_encoder,                      \
                            &(dev)->mode_config.encoder_list,   \