]> www.infradead.org Git - nvme.git/commitdiff
btrfs: zoned: fix zone finishing with missing devices
authorJohannes Thumshirn <johannes.thumshirn@wdc.com>
Mon, 17 Mar 2025 11:24:59 +0000 (12:24 +0100)
committerDavid Sterba <dsterba@suse.com>
Tue, 18 Mar 2025 19:35:57 +0000 (20:35 +0100)
If do_zone_finish() is called with a filesystem that has missing devices
(e.g. a RAID file system mounted in degraded mode) it is accessing the
btrfs_device::zone_info pointer, which will not be set if the device
in question is missing.

Check if the device is present (by checking if it has a valid block device
pointer associated) and if not, skip zone finishing for it.

Fixes: 4dcbb8ab31c1 ("btrfs: zoned: make zone finishing multi stripe capable")
CC: stable@vger.kernel.org # 6.1+
Reviewed-by: Naohiro Aota <naohiro.aota@wdc.com>
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/zoned.c

index 9faf1e097196f153b68ee114e8cdad32fbc7fcaf..fb8b8b29c169ca378102963103203508812c879c 100644 (file)
@@ -2275,6 +2275,9 @@ static int do_zone_finish(struct btrfs_block_group *block_group, bool fully_writ
                struct btrfs_zoned_device_info *zinfo = device->zone_info;
                unsigned int nofs_flags;
 
+               if (!device->bdev)
+                       continue;
+
                if (zinfo->max_active_zones == 0)
                        continue;