]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
net-sysfs: update the queue counts in the unregistration path
authorAntoine Tenart <atenart@kernel.org>
Tue, 7 Dec 2021 14:57:24 +0000 (15:57 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jan 2022 08:04:25 +0000 (09:04 +0100)
[ Upstream commit d7dac083414eb5bb99a6d2ed53dc2c1b405224e5 ]

When updating Rx and Tx queue kobjects, the queue count should always be
updated to match the queue kobjects count. This was not done in the net
device unregistration path, fix it. Tracking all queue count updates
will allow in a following up patch to detect illegal updates.

Signed-off-by: Antoine Tenart <atenart@kernel.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/core/net-sysfs.c

index fe0d255d66c8bc54ef83a3016b468f8ce6dcc9e2..e5dc04cb55992d903ece9a0663ce396fbdf4a8d2 100644 (file)
@@ -1616,6 +1616,9 @@ static void remove_queue_kobjects(struct net_device *dev)
 
        net_rx_queue_update_kobjects(dev, real_rx, 0);
        netdev_queue_update_kobjects(dev, real_tx, 0);
+
+       dev->real_num_rx_queues = 0;
+       dev->real_num_tx_queues = 0;
 #ifdef CONFIG_SYSFS
        kset_unregister(dev->queues_kset);
 #endif