]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
block: don't verify IO lock for freeze/unfreeze in elevator_init_mq()
authorMing Lei <ming.lei@redhat.com>
Thu, 31 Oct 2024 13:37:20 +0000 (21:37 +0800)
committerJens Axboe <axboe@kernel.dk>
Thu, 7 Nov 2024 23:27:22 +0000 (16:27 -0700)
elevator_init_mq() is only called at the entry of add_disk_fwnode() when
disk IO isn't allowed yet.

So not verify io lock(q->io_lockdep_map) for freeze & unfreeze in
elevator_init_mq().

Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reported-by: Lai Yi <yi1.lai@linux.intel.com>
Fixes: f1be1788a32e ("block: model freeze & enter queue as lock for supporting lockdep")
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20241031133723.303835-5-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/elevator.c

index f169f4bae91782aed02f2e243e8dec9118590209..7c3ba80e5ff4a390e62bb4318d364e95da92cd3c 100644 (file)
@@ -598,13 +598,19 @@ void elevator_init_mq(struct request_queue *q)
         * drain any dispatch activities originated from passthrough
         * requests, then no need to quiesce queue which may add long boot
         * latency, especially when lots of disks are involved.
+        *
+        * Disk isn't added yet, so verifying queue lock only manually.
         */
-       blk_mq_freeze_queue(q);
+       blk_freeze_queue_start_non_owner(q);
+       blk_freeze_acquire_lock(q, true, false);
+       blk_mq_freeze_queue_wait(q);
+
        blk_mq_cancel_work_sync(q);
 
        err = blk_mq_init_sched(q, e);
 
-       blk_mq_unfreeze_queue(q);
+       blk_unfreeze_release_lock(q, true, false);
+       blk_mq_unfreeze_queue_non_owner(q);
 
        if (err) {
                pr_warn("\"%s\" elevator initialization failed, "