]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
arm64: dts: rockchip: Move ep-gpios property to nanopc-t4 from nanopi4
authorChen-Yu Tsai <wens@csie.org>
Thu, 21 Jan 2021 16:23:20 +0000 (00:23 +0800)
committerHeiko Stuebner <heiko@sntech.de>
Mon, 25 Jan 2021 22:58:12 +0000 (23:58 +0100)
Only the NanoPC T4 hs the PCIe reset pin routed to the SoC. For the
NanoPi M4 family, no such signal is routed to the expansion header on
the base board.

As the schematics for the expansion board were not released, it is
unclear how this is handled, but the likely answer is that the signal
is always pulled high.

Move the ep-gpios property from the common nanopi4.dtsi file to the
board level nanopc-t4.dts file. This makes the nanopi-m4 lack ep-gpios,
matching the board design.

A companion patch "PCI: rockchip: make ep_gpio optional" for the Linux
driver is required, as the driver currently requires the property to be
present.

Fixes: e7a095908227 ("arm64: dts: rockchip: Add devicetree for NanoPC-T4")
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Link: https://lore.kernel.org/r/20210121162321.4538-4-wens@kernel.org
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
arch/arm64/boot/dts/rockchip/rk3399-nanopc-t4.dts
arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi

index e0d75617bb7e2b9d25656d762bee8902d2ac8f32..452728b82e42c64788974e23894443a281e9f232 100644 (file)
@@ -95,6 +95,7 @@
 };
 
 &pcie0 {
+       ep-gpios = <&gpio2 RK_PA4 GPIO_ACTIVE_HIGH>;
        num-lanes = <4>;
        vpcie3v3-supply = <&vcc3v3_sys>;
 };
index 76a8b40a93c694cff431f49d6f9f3201d6884ecf..48ed4aaa37f3d33b0572563838d5b183049f6221 100644 (file)
 };
 
 &pcie0 {
-       ep-gpios = <&gpio2 RK_PA4 GPIO_ACTIVE_HIGH>;
        max-link-speed = <2>;
        num-lanes = <2>;
        vpcie0v9-supply = <&vcca0v9_s3>;