]> www.infradead.org Git - users/willy/xarray.git/commitdiff
drm/amd/display: Drop unnecessary 'rc' variable in amdgpu_dm_backlight_get_level()
authorMario Limonciello <mario.limonciello@amd.com>
Wed, 25 Jun 2025 15:23:13 +0000 (10:23 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 28 Jul 2025 20:40:05 +0000 (16:40 -0400)
[Why]
amdgpu_dm_backlight_get_level() returns a boolean value but is assigned
to a variable named 'rc' which is generally used for return codes.

This can be confusing while looking at the code for other issues.

[How]
Drop the variable and just look directly at the return value of
amdgpu_dm_backlight_get_level() in the if statement.

Reviewed-by: Alex Hung <alex.hung@amd.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Wayne Lin <wayne.lin@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

index 2a175fc0399c264839274e9b9318e0469c37188a..bfe3ee4b07ff8c6aea5074afabcbde06b9c761a7 100644 (file)
@@ -4926,10 +4926,8 @@ static u32 amdgpu_dm_backlight_get_level(struct amdgpu_display_manager *dm,
 
        if (caps.aux_support) {
                u32 avg, peak;
-               bool rc;
 
-               rc = dc_link_get_backlight_level_nits(link, &avg, &peak);
-               if (!rc)
+               if (!dc_link_get_backlight_level_nits(link, &avg, &peak))
                        return dm->brightness[bl_idx];
                return convert_brightness_to_user(&caps, avg);
        }