]> www.infradead.org Git - qemu-nvme.git/commitdiff
gitlab: compare CIRRUS_nn vars against 'null' not ""
authorDaniel P. Berrangé <berrange@redhat.com>
Mon, 13 Jun 2022 17:12:57 +0000 (18:12 +0100)
committerAlex Bennée <alex.bennee@linaro.org>
Mon, 13 Jun 2022 23:15:06 +0000 (00:15 +0100)
The GitLab variable comparisons don't have shell like semantics where
an unset variable compares equal to empty string. We need to explicitly
test against 'null' to detect an unset variable.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Tested-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20220608160651.248781-1-berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20220613171258.1905715-7-alex.bennee@linaro.org>

.gitlab-ci.d/base.yml

index f334f3ded70ae0d66b2e8e6556c4b313fb66047b..69b36c148a963fc1cf12fd53bee24965b32bc6e6 100644 (file)
@@ -13,7 +13,7 @@
     #############################################################
 
     # Cirrus jobs can't run unless the creds / target repo are set
-    - if: '$QEMU_JOB_CIRRUS && ($CIRRUS_GITHUB_REPO == "" || $CIRRUS_API_TOKEN == "")'
+    - if: '$QEMU_JOB_CIRRUS && ($CIRRUS_GITHUB_REPO == null || $CIRRUS_API_TOKEN == null)'
       when: never
 
     # Publishing jobs should only run on the default branch in upstream