]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
scsi: qedi: Remove comparison of u16 idx with zero.
authorChristos Gkekas <chris.gekas@gmail.com>
Sat, 24 Jun 2017 16:24:45 +0000 (17:24 +0100)
committerChuck Anderson <chuck.anderson@oracle.com>
Tue, 19 Sep 2017 05:32:51 +0000 (22:32 -0700)
Orabug: 26759520

Variable idx is defined as u16 thus statement (idx < 0) is always false
and should be removed.

Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
Acked-by: Manish Rangankar <Manish.Rangankar@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Brian Maly <brian.maly@oracle.com>
drivers/scsi/qedi/qedi_fw.c

index 05db28a44227c0f2ca40b2f69fd4b633ccbcba6d..7139fdc0f3b9b94ff6192bdc2d8b0c591d588d4e 100644 (file)
@@ -333,7 +333,7 @@ static void qedi_get_rq_bdq_buf(struct qedi_ctx *qedi,
 
        /* Obtain buffer address from rqe_opaque */
        idx = cqe->rqe_opaque.lo;
-       if ((idx < 0) || (idx > (QEDI_BDQ_NUM - 1))) {
+       if (idx > (QEDI_BDQ_NUM - 1)) {
                QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_CONN,
                          "wrong idx %d returned by FW, dropping the unsolicited pkt\n",
                          idx);
@@ -370,7 +370,7 @@ static void qedi_put_rq_bdq_buf(struct qedi_ctx *qedi,
 
        /* Obtain buffer address from rqe_opaque */
        idx = cqe->rqe_opaque.lo;
-       if ((idx < 0) || (idx > (QEDI_BDQ_NUM - 1))) {
+       if (idx > (QEDI_BDQ_NUM - 1)) {
                QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_CONN,
                          "wrong idx %d returned by FW, dropping the unsolicited pkt\n",
                          idx);