tracing: Fix uninitialized buffer var on early exit to trace_vbprintk()

If we exit due to a bad input to trace_printk() (highly unlikely), then the
buffer variable will not be initialized when we unnest the ring buffer.

Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 2e1db19dce9738328b25ed9471f8261874418c4f..d1410b4462ac4e2ebd894fd6b854260d52454bb1 100644 (file)
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -3230,7 +3230,7 @@ int trace_vbprintk(unsigned long ip, const char *fmt, va_list args)
        len = vbin_printf((u32 *)tbuffer, TRACE_BUF_SIZE/sizeof(int), fmt, args);
 
        if (len > TRACE_BUF_SIZE/sizeof(int) || len < 0)
-               goto out;
+               goto out_put;
 
        local_save_flags(flags);
        size = sizeof(*entry) + sizeof(u32) * len;
@@ -3252,6 +3252,7 @@ int trace_vbprintk(unsigned long ip, const char *fmt, va_list args)
 
 out:
        ring_buffer_nest_end(buffer);
+out_put:
        put_trace_buf();
 
 out_nobuffer: