]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
can: slcan: use the generic can_change_mtu()
authorDario Binacchi <dario.binacchi@amarulasolutions.com>
Thu, 28 Jul 2022 07:02:52 +0000 (09:02 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Thu, 28 Jul 2022 07:14:42 +0000 (09:14 +0200)
It is useless to define a custom function that does nothing but always
return the same error code. Better to use the generic can_change_mtu()
function.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Link: https://lore.kernel.org/all/20220728070254.267974-6-dario.binacchi@amarulasolutions.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/slcan/slcan-core.c

index 3a4701d8e081e6896ec5cf571744d0c58bca4d1d..740d82d68ca42f5b811f04fa4107cf090eb4b557 100644 (file)
@@ -743,16 +743,11 @@ cmd_transmit_failed:
        return err;
 }
 
-static int slcan_netdev_change_mtu(struct net_device *dev, int new_mtu)
-{
-       return -EINVAL;
-}
-
 static const struct net_device_ops slcan_netdev_ops = {
        .ndo_open               = slcan_netdev_open,
        .ndo_stop               = slcan_netdev_close,
        .ndo_start_xmit         = slcan_netdev_xmit,
-       .ndo_change_mtu         = slcan_netdev_change_mtu,
+       .ndo_change_mtu         = can_change_mtu,
 };
 
 /******************************************