]> www.infradead.org Git - users/hch/misc.git/commitdiff
media: i2c: ov2659: Use the v4l2 helper for obtaining the clock
authorMehdi Djait <mehdi.djait@linux.intel.com>
Thu, 26 Jun 2025 13:34:17 +0000 (15:34 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Wed, 13 Aug 2025 13:10:24 +0000 (15:10 +0200)
devm_clk_get() fails on ACPI-based platforms, where firmware does not
provide a direct reference to the clock producer.

Replace devm_clk_get() with the new v4l2 helper
devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based
platforms to retrieve a reference to the clock producer from firmware.

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mehdi Djait <mehdi.djait@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/ov2659.c

index 586b31ba076b60b420f8e910a66632b89ea02ae2..061401b020fcb48157d229908967709e59fe3019 100644 (file)
@@ -1437,9 +1437,10 @@ static int ov2659_probe(struct i2c_client *client)
        ov2659->pdata = pdata;
        ov2659->client = client;
 
-       ov2659->clk = devm_clk_get(&client->dev, "xvclk");
+       ov2659->clk = devm_v4l2_sensor_clk_get(&client->dev, "xvclk");
        if (IS_ERR(ov2659->clk))
-               return PTR_ERR(ov2659->clk);
+               return dev_err_probe(&client->dev, PTR_ERR(ov2659->clk),
+                                    "failed to get xvclk\n");
 
        ov2659->xvclk_frequency = clk_get_rate(ov2659->clk);
        if (ov2659->xvclk_frequency < 6000000 ||