]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
iio: dummy: iio_simply_dummy_buffer: fix information leak in triggered buffer
authorJavier Carrasco <javier.carrasco.cruz@gmail.com>
Mon, 25 Nov 2024 21:16:17 +0000 (22:16 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 7 Dec 2024 17:23:41 +0000 (17:23 +0000)
The 'data' array is allocated via kmalloc() and it is used to push data
to user space from a triggered buffer, but it does not set values for
inactive channels, as it only uses iio_for_each_active_channel()
to assign new values.

Use kzalloc for the memory allocation to avoid pushing uninitialized
information to userspace.

Cc: stable@vger.kernel.org
Fixes: 415f79244757 ("iio: Move IIO Dummy Driver out of staging")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Link: https://patch.msgid.link/20241125-iio_memset_scan_holes-v1-9-0cb6e98d895c@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/dummy/iio_simple_dummy_buffer.c

index 4ca3f1aaff99969f5ffe86462439fe5bfbaa446e..288880346707a2b5b58332ddc4c4d7ef5701ba4b 100644 (file)
@@ -48,7 +48,7 @@ static irqreturn_t iio_simple_dummy_trigger_h(int irq, void *p)
        int i = 0, j;
        u16 *data;
 
-       data = kmalloc(indio_dev->scan_bytes, GFP_KERNEL);
+       data = kzalloc(indio_dev->scan_bytes, GFP_KERNEL);
        if (!data)
                goto done;