]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
i2c: rcar: WARN about spurious irqs
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Sun, 7 Jul 2024 08:28:47 +0000 (10:28 +0200)
committerAndi Shyti <andi.shyti@kernel.org>
Wed, 10 Jul 2024 07:57:49 +0000 (09:57 +0200)
The FIXME is very old and probably needed because of some driver bug
like insufficient initialization. It may well be that it was fixed
meanwhile but we never know because the spurious irq is silently
ignored. Add now a call trace when this happens so we have more
information in case the issue still exists.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-rcar.c

index 828aa2ea0fe4c90785cbdc5e65b5b28cdf86b40b..efa30607649307f3b0bc03125ec9d0a2bca015ee 100644 (file)
@@ -545,7 +545,7 @@ static void rcar_i2c_irq_send(struct rcar_i2c_priv *priv, u32 msr)
        u32 irqs_to_clear = MDE;
 
        /* FIXME: sometimes, unknown interrupt happened. Do nothing */
-       if (!(msr & MDE))
+       if (WARN(!(msr & MDE), "spurious irq"))
                return;
 
        if (msr & MAT)