]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
net :mana :Request a V2 response version for MANA_QUERY_GF_STAT
authorShradha Gupta <shradhagupta@linux.microsoft.com>
Wed, 4 Dec 2024 05:48:20 +0000 (21:48 -0800)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 5 Dec 2024 11:02:15 +0000 (12:02 +0100)
The current requested response version(V1) for MANA_QUERY_GF_STAT query
results in STATISTICS_FLAGS_TX_ERRORS_GDMA_ERROR value being set to
0 always.
In order to get the correct value for this counter we request the response
version to be V2.

Cc: stable@vger.kernel.org
Fixes: e1df5202e879 ("net :mana :Add remaining GDMA stats for MANA to ethtool")
Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com>
Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
Link: https://patch.msgid.link/1733291300-12593-1-git-send-email-shradhagupta@linux.microsoft.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/microsoft/mana/mana_en.c

index 57ac732e77074b38a305a6311b269582e688c3fe..f73848a4feb3d41b71bf59af9080c2e58a0a9e63 100644 (file)
@@ -2536,6 +2536,7 @@ void mana_query_gf_stats(struct mana_port_context *apc)
 
        mana_gd_init_req_hdr(&req.hdr, MANA_QUERY_GF_STAT,
                             sizeof(req), sizeof(resp));
+       req.hdr.resp.msg_version = GDMA_MESSAGE_V2;
        req.req_stats = STATISTICS_FLAGS_RX_DISCARDS_NO_WQE |
                        STATISTICS_FLAGS_RX_ERRORS_VPORT_DISABLED |
                        STATISTICS_FLAGS_HC_RX_BYTES |