]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
platform/x86: think-lmi: Use 2-argument strscpy()
authorAndy Shevchenko <andy.shevchenko@gmail.com>
Sun, 2 Jun 2024 08:57:58 +0000 (11:57 +0300)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Mon, 3 Jun 2024 11:51:42 +0000 (14:51 +0300)
Use 2-argument strscpy(), which is not only shorter but also provides
an additional check that destination buffer is an array.

Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20240602090244.1666360-6-andy.shevchenko@gmail.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/think-lmi.c

index 0f2264bb75775cba72f65a88fd0a86e9230cb395..4cfb53206cb848ba30d628a3476791c046dcd592 100644 (file)
@@ -1508,7 +1508,7 @@ static struct tlmi_pwd_setting *tlmi_create_auth(const char *pwd_type,
        if (!new_pwd)
                return NULL;
 
-       strscpy(new_pwd->kbdlang, "us", TLMI_LANG_MAXLEN);
+       strscpy(new_pwd->kbdlang, "us");
        new_pwd->encoding = TLMI_ENCODING_ASCII;
        new_pwd->pwd_type = pwd_type;
        new_pwd->role = pwd_role;
@@ -1582,7 +1582,7 @@ static int tlmi_analyze(void)
                        goto fail_clear_attr;
                }
                setting->index = i;
-               strscpy(setting->display_name, item, TLMI_SETTINGS_MAXLEN);
+               strscpy(setting->display_name, item);
                /* If BIOS selections supported, load those */
                if (tlmi_priv.can_get_bios_selections) {
                        ret = tlmi_get_bios_selections(setting->display_name,