]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
crash, powerpc: default to CRASH_DUMP=n on PPC_BOOK3S_32
authorDave Vasilevsky <dave@vasilevsky.ca>
Tue, 17 Sep 2024 16:37:20 +0000 (12:37 -0400)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 15 Nov 2024 06:43:48 +0000 (22:43 -0800)
Fixes boot failures on 6.9 on PPC_BOOK3S_32 machines using Open Firmware.
On these machines, the kernel refuses to boot from non-zero
PHYSICAL_START, which occurs when CRASH_DUMP is on.

Since most PPC_BOOK3S_32 machines boot via Open Firmware, it should
default to off for them.  Users booting via some other mechanism can still
turn it on explicitly.

Does not change the default on any other architectures for the
time being.

Link: https://lkml.kernel.org/r/20240917163720.1644584-1-dave@vasilevsky.ca
Fixes: 75bc255a7444 ("crash: clean up kdump related config items")
Signed-off-by: Dave Vasilevsky <dave@vasilevsky.ca>
Reported-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
Closes: https://lists.debian.org/debian-powerpc/2024/07/msg00001.html
Acked-by: Michael Ellerman <mpe@ellerman.id.au> [powerpc]
Acked-by: Baoquan He <bhe@redhat.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
arch/arm/Kconfig
arch/arm64/Kconfig
arch/loongarch/Kconfig
arch/mips/Kconfig
arch/powerpc/Kconfig
arch/riscv/Kconfig
arch/s390/Kconfig
arch/sh/Kconfig
arch/x86/Kconfig
kernel/Kconfig.kexec

index 749179a1d16297498eb542235b8003eeda6c2582..202397be76d8037b531b34dee16c7dfcfd0124ef 100644 (file)
@@ -1598,6 +1598,9 @@ config ATAGS_PROC
 config ARCH_SUPPORTS_CRASH_DUMP
        def_bool y
 
+config ARCH_DEFAULT_CRASH_DUMP
+       def_bool y
+
 config AUTO_ZRELADDR
        bool "Auto calculation of the decompressed kernel image address" if !ARCH_MULTIPLATFORM
        default !(ARCH_FOOTBRIDGE || ARCH_RPC || ARCH_SA1100)
index fd9df6dcc5937208fe158ac8da9c4ede131d0fc7..22ea2705becc58de3a6b2903fbabf7b8b5f91304 100644 (file)
@@ -1576,6 +1576,9 @@ config ARCH_DEFAULT_KEXEC_IMAGE_VERIFY_SIG
 config ARCH_SUPPORTS_CRASH_DUMP
        def_bool y
 
+config ARCH_DEFAULT_CRASH_DUMP
+       def_bool y
+
 config ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION
        def_bool CRASH_RESERVE
 
index bb35c34f86d23a1cc6f049ad727bea236f700389..d9fce0fd475a049e4eae98caf448a70ee0f57d1f 100644 (file)
@@ -604,6 +604,9 @@ config ARCH_SUPPORTS_KEXEC
 config ARCH_SUPPORTS_CRASH_DUMP
        def_bool y
 
+config ARCH_DEFAULT_CRASH_DUMP
+       def_bool y
+
 config ARCH_SELECTS_CRASH_DUMP
        def_bool y
        depends on CRASH_DUMP
index 397edf05dd722556ef7a5bb151546d38243dba2b..467b10f4361aeb7aad0121f334eaa5d23351010c 100644 (file)
@@ -2876,6 +2876,9 @@ config ARCH_SUPPORTS_KEXEC
 config ARCH_SUPPORTS_CRASH_DUMP
        def_bool y
 
+config ARCH_DEFAULT_CRASH_DUMP
+       def_bool y
+
 config PHYSICAL_START
        hex "Physical address where the kernel is loaded"
        default "0xffffffff84000000"
index 8094a01974cca1d27002720e706f66bec2a2d035..1a2ff0276365b498e55a4e226396e73d6f9d6d3d 100644 (file)
@@ -684,6 +684,10 @@ config RELOCATABLE_TEST
 config ARCH_SUPPORTS_CRASH_DUMP
        def_bool PPC64 || PPC_BOOK3S_32 || PPC_85xx || (44x && !SMP)
 
+config ARCH_DEFAULT_CRASH_DUMP
+       bool
+       default y if !PPC_BOOK3S_32
+
 config ARCH_SELECTS_CRASH_DUMP
        def_bool y
        depends on CRASH_DUMP
index f4c570538d55b17b33a22dd78be149fb62480706..fa8f2da87a0a8348b886a9adc8f3e887005571e7 100644 (file)
@@ -898,6 +898,9 @@ config ARCH_SUPPORTS_KEXEC_PURGATORY
 config ARCH_SUPPORTS_CRASH_DUMP
        def_bool y
 
+config ARCH_DEFAULT_CRASH_DUMP
+       def_bool y
+
 config ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION
        def_bool CRASH_RESERVE
 
index d339fe4fdedf881fd9224020381a1c7f62998d59..cc1f9cffe2a5f434f08a05954b9f8dd5fab9b796 100644 (file)
@@ -276,6 +276,9 @@ config ARCH_SUPPORTS_CRASH_DUMP
          This option also enables s390 zfcpdump.
          See also <file:Documentation/arch/s390/zfcpdump.rst>
 
+config ARCH_DEFAULT_CRASH_DUMP
+       def_bool y
+
 menu "Processor type and features"
 
 config HAVE_MARCH_Z10_FEATURES
index e9103998cca91fb18cc9d6288a103dd90151edec..04ff5fb9242edd2babc4737ade679fa4ae11e86d 100644 (file)
@@ -550,6 +550,9 @@ config ARCH_SUPPORTS_KEXEC
 config ARCH_SUPPORTS_CRASH_DUMP
        def_bool BROKEN_ON_SMP
 
+config ARCH_DEFAULT_CRASH_DUMP
+       def_bool y
+
 config ARCH_SUPPORTS_KEXEC_JUMP
        def_bool y
 
index 16354dfa6d965042e46fde64092c6230cd1d9eaa..7b9a7e8f39acc8e9aeb7d4213e87d71047865f5c 100644 (file)
@@ -2084,6 +2084,9 @@ config ARCH_SUPPORTS_KEXEC_JUMP
 config ARCH_SUPPORTS_CRASH_DUMP
        def_bool X86_64 || (X86_32 && HIGHMEM)
 
+config ARCH_DEFAULT_CRASH_DUMP
+       def_bool y
+
 config ARCH_SUPPORTS_CRASH_HOTPLUG
        def_bool y
 
index 6c34e63c88ff4c1e23fb0ba14c4002fcfb7783ed..4d111f871951676544ed248b394c22b157b9536a 100644 (file)
@@ -97,7 +97,7 @@ config KEXEC_JUMP
 
 config CRASH_DUMP
        bool "kernel crash dumps"
-       default y
+       default ARCH_DEFAULT_CRASH_DUMP
        depends on ARCH_SUPPORTS_CRASH_DUMP
        depends on KEXEC_CORE
        select VMCORE_INFO