]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
ASoC: codecs: rt5677: use new GPIO line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 8 Apr 2025 07:38:23 +0000 (09:38 +0200)
committerMark Brown <broonie@kernel.org>
Sun, 13 Apr 2025 19:23:18 +0000 (20:23 +0100)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://patch.msgid.link/20250408-gpiochip-set-rv-sound-v1-5-dd54b6ca1ef9@linaro.org
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt5677.c

index 6e47741485663732555e7640aad40cc8da1f8d4d..69a0fb8d7f770a80246aa44636b62ed3ea90e238 100644 (file)
@@ -4725,13 +4725,14 @@ static int rt5677_update_gpio_bits(struct rt5677_priv *rt5677, unsigned offset,
 }
 
 #ifdef CONFIG_GPIOLIB
-static void rt5677_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
+static int rt5677_gpio_set(struct gpio_chip *chip, unsigned int offset,
+                          int value)
 {
        struct rt5677_priv *rt5677 = gpiochip_get_data(chip);
        int level = value ? RT5677_GPIOx_OUT_HI : RT5677_GPIOx_OUT_LO;
        int m = RT5677_GPIOx_OUT_MASK;
 
-       rt5677_update_gpio_bits(rt5677, offset, m, level);
+       return rt5677_update_gpio_bits(rt5677, offset, m, level);
 }
 
 static int rt5677_gpio_direction_out(struct gpio_chip *chip,
@@ -4834,7 +4835,7 @@ static const struct gpio_chip rt5677_template_chip = {
        .label                  = RT5677_DRV_NAME,
        .owner                  = THIS_MODULE,
        .direction_output       = rt5677_gpio_direction_out,
-       .set                    = rt5677_gpio_set,
+       .set_rv                 = rt5677_gpio_set,
        .direction_input        = rt5677_gpio_direction_in,
        .get                    = rt5677_gpio_get,
        .to_irq                 = rt5677_to_irq,