]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
drm/amdgpu: Move the dumping log out of for loop
authorSunil Khatri <sunil.khatri@amd.com>
Wed, 28 Aug 2024 08:06:23 +0000 (13:36 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 29 Aug 2024 17:39:19 +0000 (13:39 -0400)
log message "Dumping IP State Completed" needs to
be logged only once when state dumping is complete.

Hence moving it out of the for loop.

Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
Acked-by: Trigger Huang <Trigger.Huang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c

index 76561e5400eb01c2ab24448264c30190170d417b..ad6bf5d4e0a9d03a805f6378bb9fd25b9e98880d 100644 (file)
@@ -39,12 +39,11 @@ static void amdgpu_job_do_core_dump(struct amdgpu_device *adev,
        int i;
 
        dev_info(adev->dev, "Dumping IP State\n");
-       for (i = 0; i < adev->num_ip_blocks; i++) {
+       for (i = 0; i < adev->num_ip_blocks; i++)
                if (adev->ip_blocks[i].version->funcs->dump_ip_state)
                        adev->ip_blocks[i].version->funcs
                                ->dump_ip_state((void *)adev);
-               dev_info(adev->dev, "Dumping IP State Completed\n");
-       }
+       dev_info(adev->dev, "Dumping IP State Completed\n");
 
        amdgpu_coredump(adev, true, false, job);
 }