]> www.infradead.org Git - users/borneoa/openocd-next.git/commitdiff
OpenOCD: fix code indentation
authorAntonio Borneo <borneo.antonio@gmail.com>
Mon, 16 Sep 2024 11:45:19 +0000 (13:45 +0200)
committerAntonio Borneo <borneo.antonio@gmail.com>
Sat, 25 Jan 2025 10:31:06 +0000 (10:31 +0000)
Fix checkpatch errors

ERROR:SUSPECT_CODE_INDENT: suspect code indent for
conditional statements

Change-Id: I94d4fa5720c25dd2fb0334a824cd9026babcce4e
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/8497
Tested-by: jenkins
17 files changed:
src/flash/nor/fespi.c
src/flash/nor/kinetis_ke.c
src/flash/nor/niietcm4.c
src/flash/nor/psoc4.c
src/helper/log.c
src/rtos/hwthread.c
src/rtos/linux.c
src/target/aarch64.c
src/target/arc.c
src/target/armv4_5.c
src/target/armv7a_mmu.c
src/target/armv8.c
src/target/cortex_a.c
src/target/mips32.c
src/target/mips_m4k.c
src/target/stm8.c
src/xsvf/xsvf.c

index 6c4e8a928f6940205a670dd082c48007cbdafeb4..395722cb5d4d119193bf88aa886e2b8fdd023416 100644 (file)
@@ -751,9 +751,9 @@ static int fespi_probe(struct flash_bank *bank)
                                target_device->name, bank->base);
 
        } else {
-         LOG_DEBUG("Assuming FESPI as specified at address " TARGET_ADDR_FMT
-                         " with ctrl at " TARGET_ADDR_FMT, fespi_info->ctrl_base,
-                         bank->base);
+               LOG_DEBUG("Assuming FESPI as specified at address " TARGET_ADDR_FMT
+                                 " with ctrl at " TARGET_ADDR_FMT, fespi_info->ctrl_base,
+                                 bank->base);
        }
 
        /* read and decode flash ID; returns in SW mode */
index e4dffa6d5c4e153c51883469b5ed0088c9f381ce..8207504b5f4dc7b88cda792eaca6f14d3fbfe227 100644 (file)
@@ -1005,7 +1005,7 @@ static int kinetis_ke_write(struct flash_bank *bank, const uint8_t *buffer,
 
        result = kinetis_ke_stop_watchdog(bank->target);
        if (result != ERROR_OK)
-                       return result;
+               return result;
 
        result = kinetis_ke_prepare_flash(bank);
        if (result != ERROR_OK)
index 0c36e2c96d2e46252cda46410fc5527f6373e6ad..aaf0726550e66f12f55e97955c36c10ae5719830 100644 (file)
@@ -311,7 +311,7 @@ static int niietcm4_uflash_page_erase(struct flash_bank *bank, int page_num, int
        /* status check */
        retval = niietcm4_uopstatus_check(bank);
        if (retval != ERROR_OK)
-                       return retval;
+               return retval;
 
        return retval;
 }
@@ -394,7 +394,7 @@ COMMAND_HANDLER(niietcm4_handle_uflash_read_byte_command)
        uint32_t uflash_data;
 
        if (strcmp("info", CMD_ARGV[0]) == 0)
-                       uflash_cmd = UFMC_MAGIC_KEY | UFMC_READ_IFB;
+               uflash_cmd = UFMC_MAGIC_KEY | UFMC_READ_IFB;
        else if (strcmp("main", CMD_ARGV[0]) == 0)
                uflash_cmd = UFMC_MAGIC_KEY | UFMC_READ;
        else
@@ -539,7 +539,7 @@ COMMAND_HANDLER(niietcm4_handle_uflash_erase_command)
        int mem_type;
 
        if (strcmp("info", CMD_ARGV[0]) == 0)
-                       mem_type = 1;
+               mem_type = 1;
        else if (strcmp("main", CMD_ARGV[0]) == 0)
                mem_type = 0;
        else
index 1064fa93d3e9197624b383adccd73405afd2a703..72cf0ee05b81d9d96adde947c2318f80047a5535 100644 (file)
@@ -384,15 +384,15 @@ static int psoc4_get_silicon_id(struct flash_bank *bank, uint32_t *silicon_id, u
         * bit 7..0   family ID (lowest 8 bits)
         */
        if (silicon_id)
-                       *silicon_id = ((part0 & 0x0000ffff) << 16)
-                                   | ((part0 & 0x00ff0000) >> 8)
-                                   | (part1 & 0x000000ff);
+               *silicon_id = ((part0 & 0x0000ffff) << 16)
+                                         | ((part0 & 0x00ff0000) >> 8)
+                                         | (part1 & 0x000000ff);
 
        if (family_id)
-                       *family_id = part1 & 0x0fff;
+               *family_id = part1 & 0x0fff;
 
        if (protection)
-                       *protection = (part1 >> 12) & 0x0f;
+               *protection = (part1 >> 12) & 0x0f;
 
        return ERROR_OK;
 }
index 9ad00ce628a4c550b3c2cd2f48d042470113aecc..e02556b6dbde5d73bfdeb158105db64ce2ed55e9 100644 (file)
@@ -272,10 +272,10 @@ void log_init(void)
        if (debug_env) {
                int value;
                int retval = parse_int(debug_env, &value);
-               if (retval == ERROR_OK &&
-                               debug_level >= LOG_LVL_SILENT &&
-                               debug_level <= LOG_LVL_DEBUG_IO)
-                               debug_level = value;
+               if (retval == ERROR_OK
+                               && debug_level >= LOG_LVL_SILENT
+                               && debug_level <= LOG_LVL_DEBUG_IO)
+                       debug_level = value;
        }
 
        if (!log_output)
index 1890a3d87a31a49ddb6c8125739867ad0b91a34e..c9f1a179202d8cbc5b009c0240cbdaaba68aff58 100644 (file)
@@ -154,9 +154,8 @@ static int hwthread_update_threads(struct rtos *rtos)
                                if (curr->debug_reason == DBG_REASON_SINGLESTEP) {
                                        current_reason = curr->debug_reason;
                                        current_thread = tid;
-                               } else
-                               /* multiple breakpoints, prefer gdbs' threadid */
-                               if (curr->debug_reason == DBG_REASON_BREAKPOINT) {
+                               } else if (curr->debug_reason == DBG_REASON_BREAKPOINT) {
+                                       /* multiple breakpoints, prefer gdbs' threadid */
                                        if (tid == rtos->current_threadid)
                                                current_thread = tid;
                                }
@@ -176,8 +175,7 @@ static int hwthread_update_threads(struct rtos *rtos)
                                                curr->debug_reason == DBG_REASON_BREAKPOINT) {
                                        current_reason = curr->debug_reason;
                                        current_thread = tid;
-                               } else
-                               if (curr->debug_reason == DBG_REASON_DBGRQ) {
+                               } else if (curr->debug_reason == DBG_REASON_DBGRQ) {
                                        if (tid == rtos->current_threadid)
                                                current_thread = tid;
                                }
index 7517ec7a9a5d85618e601adf617b9fa420c4cb00..5467988f3e761922c4e299937fe5fb44e92bda4e 100644 (file)
@@ -624,7 +624,7 @@ static struct threads *liste_add_task(struct threads *task_list, struct threads
 {
        t->next = NULL;
 
-       if (!*last)
+       if (!*last) {
                if (!task_list) {
                        task_list = t;
                        return task_list;
@@ -637,7 +637,8 @@ static struct threads *liste_add_task(struct threads *task_list, struct threads
                        temp->next = t;
                        *last = t;
                        return task_list;
-               } else {
+               }
+       } else {
                (*last)->next = t;
                *last = t;
                return task_list;
index 9f122070aa691c0db4bfcb9c396e0280d535eb65..3cc8130054bd4b5c2f6493f63235365027e539fb 100644 (file)
@@ -2908,9 +2908,9 @@ static int aarch64_jim_configure(struct target *target, struct jim_getopt_info *
 
        pc = (struct aarch64_private_config *)target->private_config;
        if (!pc) {
-                       pc = calloc(1, sizeof(struct aarch64_private_config));
-                       pc->adiv5_config.ap_num = DP_APSEL_INVALID;
-                       target->private_config = pc;
+               pc = calloc(1, sizeof(struct aarch64_private_config));
+               pc->adiv5_config.ap_num = DP_APSEL_INVALID;
+               target->private_config = pc;
        }
 
        /*
index 5c08c5664cca232a6d620cd76c3a1f2e0627a661..0c111d553bfd026e9496e1a62549555432fabdea 100644 (file)
@@ -388,7 +388,7 @@ static int arc_build_reg_cache(struct target *target)
        }
 
        list_for_each_entry(reg_desc, &arc->aux_reg_descriptions, list) {
-                CHECK_RETVAL(arc_init_reg(target, &reg_list[i],  reg_desc, i));
+               CHECK_RETVAL(arc_init_reg(target, &reg_list[i], reg_desc, i));
 
                LOG_TARGET_DEBUG(target, "reg n=%3li name=%3s group=%s feature=%s", i,
                        reg_list[i].name, reg_list[i].group,
@@ -464,7 +464,7 @@ static int arc_build_bcr_reg_cache(struct target *target)
        }
 
        list_for_each_entry(reg_desc, &arc->bcr_reg_descriptions, list) {
-                CHECK_RETVAL(arc_init_reg(target, &reg_list[i], reg_desc, gdb_regnum));
+               CHECK_RETVAL(arc_init_reg(target, &reg_list[i], reg_desc, gdb_regnum));
                /* BCRs always semantically, they are just read-as-zero, if there is
                 * not real register. */
                reg_list[i].exist = true;
@@ -719,14 +719,14 @@ static int arc_configure(struct target *target)
        LOG_TARGET_DEBUG(target, "Configuring ARC ICCM and DCCM");
 
        /* Configuring DCCM if DCCM_BUILD and AUX_DCCM are known registers. */
-       if (arc_reg_get_by_name(target->reg_cache, "dccm_build", true) &&
-           arc_reg_get_by_name(target->reg_cache, "aux_dccm", true))
-                               CHECK_RETVAL(arc_configure_dccm(target));
+       if (arc_reg_get_by_name(target->reg_cache, "dccm_build", true)
+                   && arc_reg_get_by_name(target->reg_cache, "aux_dccm", true))
+               CHECK_RETVAL(arc_configure_dccm(target));
 
        /* Configuring ICCM if ICCM_BUILD and AUX_ICCM are known registers. */
-       if (arc_reg_get_by_name(target->reg_cache, "iccm_build", true) &&
-           arc_reg_get_by_name(target->reg_cache, "aux_iccm", true))
-                               CHECK_RETVAL(arc_configure_iccm(target));
+       if (arc_reg_get_by_name(target->reg_cache, "iccm_build", true)
+                       && arc_reg_get_by_name(target->reg_cache, "aux_iccm", true))
+               CHECK_RETVAL(arc_configure_iccm(target));
 
        return ERROR_OK;
 }
@@ -1067,9 +1067,7 @@ static int arc_poll(struct target *target)
                        LOG_TARGET_DEBUG(target, "Discrepancy of STATUS32[0] HALT bit and ARC_JTAG_STAT_RU, "
                                                "target is still running");
                }
-
        } else if (target->state == TARGET_DEBUG_RUNNING) {
-
                target->state = TARGET_HALTED;
                LOG_TARGET_DEBUG(target, "ARC core is in debug running mode");
 
index ceec3619b565f470a4662ec381f1a46884f401af..a258c7fd4542f5ad8dcc3e93cd6f2875edd4f516 100644 (file)
@@ -1301,11 +1301,11 @@ int arm_get_gdb_reg_list(struct target *target,
                *reg_list = malloc(sizeof(struct reg *) * (*reg_list_size));
 
                for (i = 0; i < 16; i++)
-                               (*reg_list)[i] = arm_reg_current(arm, i);
+                       (*reg_list)[i] = arm_reg_current(arm, i);
 
                /* For GDB compatibility, take FPA registers size into account and zero-fill it*/
                for (i = 16; i < 24; i++)
-                               (*reg_list)[i] = &arm_gdb_dummy_fp_reg;
+                       (*reg_list)[i] = &arm_gdb_dummy_fp_reg;
                (*reg_list)[24] = &arm_gdb_dummy_fps_reg;
 
                (*reg_list)[25] = arm->cpsr;
@@ -1330,25 +1330,25 @@ int arm_get_gdb_reg_list(struct target *target,
                *reg_list = malloc(sizeof(struct reg *) * (*reg_list_size));
 
                for (i = 0; i < 16; i++)
-                               (*reg_list)[i] = arm_reg_current(arm, i);
+                       (*reg_list)[i] = arm_reg_current(arm, i);
 
                for (i = 13; i < ARRAY_SIZE(arm_core_regs); i++) {
-                               int reg_index = arm->core_cache->reg_list[i].number;
+                       int reg_index = arm->core_cache->reg_list[i].number;
 
-                               if (arm_core_regs[i].mode == ARM_MODE_MON
+                       if (arm_core_regs[i].mode == ARM_MODE_MON
                                        && arm->core_type != ARM_CORE_TYPE_SEC_EXT
                                        && arm->core_type != ARM_CORE_TYPE_VIRT_EXT)
-                                       continue;
-                               if (arm_core_regs[i].mode == ARM_MODE_HYP
+                               continue;
+                       if (arm_core_regs[i].mode == ARM_MODE_HYP
                                        && arm->core_type != ARM_CORE_TYPE_VIRT_EXT)
-                                       continue;
-                               (*reg_list)[reg_index] = &(arm->core_cache->reg_list[i]);
+                               continue;
+                       (*reg_list)[reg_index] = &arm->core_cache->reg_list[i];
                }
 
                /* When we supply the target description, there is no need for fake FPA */
                for (i = 16; i < 24; i++) {
-                               (*reg_list)[i] = &arm_gdb_dummy_fp_reg;
-                               (*reg_list)[i]->size = 0;
+                       (*reg_list)[i] = &arm_gdb_dummy_fp_reg;
+                       (*reg_list)[i]->size = 0;
                }
                (*reg_list)[24] = &arm_gdb_dummy_fps_reg;
                (*reg_list)[24]->size = 0;
index c4d294eae3cb7e661f7216ffce9c2744f6f82409..43b5dae8ef50c2554d8ef80963203cfc09fb0d8b 100644 (file)
@@ -260,8 +260,7 @@ COMMAND_HANDLER(armv7a_mmu_dump_table)
                /* skip empty entries in the first level table */
                if ((first_lvl_descriptor & 3) == 0) {
                        pt_idx++;
-               } else
-               if ((first_lvl_descriptor & 0x40002) == 2) {
+               } else if ((first_lvl_descriptor & 0x40002) == 2) {
                        /* section descriptor */
                        uint32_t va_range = 1024*1024-1; /* 1MB range */
                        uint32_t va_start = pt_idx << 20;
@@ -273,8 +272,7 @@ COMMAND_HANDLER(armv7a_mmu_dump_table)
                        LOG_USER("SECT: VA[%8.8"PRIx32" -- %8.8"PRIx32"]: PA[%8.8"PRIx32" -- %8.8"PRIx32"] %s",
                                va_start, va_end, pa_start, pa_end, l1_desc_bits_to_string(first_lvl_descriptor, afe));
                        pt_idx++;
-               } else
-               if ((first_lvl_descriptor & 0x40002) == 0x40002) {
+               } else if ((first_lvl_descriptor & 0x40002) == 0x40002) {
                        /* supersection descriptor */
                        uint32_t va_range = 16*1024*1024-1; /* 16MB range */
                        uint32_t va_start = pt_idx << 20;
@@ -310,8 +308,7 @@ COMMAND_HANDLER(armv7a_mmu_dump_table)
                                if ((second_lvl_descriptor & 3) == 0) {
                                        /* skip entry */
                                        pt2_idx++;
-                               } else
-                               if ((second_lvl_descriptor & 3) == 1) {
+                               } else if ((second_lvl_descriptor & 3) == 1) {
                                        /* large page */
                                        uint32_t va_range = 64*1024-1; /* 64KB range */
                                        uint32_t va_start = (pt_idx << 20) + (pt2_idx << 12);
index 88534d9626266e675fcd058f2a61acfb40e83d4f..50a9f46883ccba540998b1e6b5c480a3d2973a9e 100644 (file)
@@ -1966,7 +1966,7 @@ int armv8_get_gdb_reg_list(struct target *target,
                        *reg_list = malloc(sizeof(struct reg *) * (*reg_list_size));
 
                        for (i = 0; i < *reg_list_size; i++)
-                                       (*reg_list)[i] = armv8_reg_current(arm, i);
+                               (*reg_list)[i] = armv8_reg_current(arm, i);
                        return ERROR_OK;
 
                case REG_CLASS_ALL:
@@ -1974,7 +1974,7 @@ int armv8_get_gdb_reg_list(struct target *target,
                        *reg_list = malloc(sizeof(struct reg *) * (*reg_list_size));
 
                        for (i = 0; i < *reg_list_size; i++)
-                                       (*reg_list)[i] = armv8_reg_current(arm, i);
+                               (*reg_list)[i] = armv8_reg_current(arm, i);
 
                        return ERROR_OK;
 
index 086aafe19941f358ff5da60b937dfe4978926b03..bfe698051858ccdbee5fabc6243503370bebd4e2 100644 (file)
@@ -1324,21 +1324,21 @@ static int cortex_a_set_breakpoint(struct target *target,
                        brp_list[brp_i].value);
        } else if (breakpoint->type == BKPT_SOFT) {
                uint8_t code[4];
-               /* length == 2: Thumb breakpoint */
-               if (breakpoint->length == 2)
+               if (breakpoint->length == 2) {
+                       /* length == 2: Thumb breakpoint */
                        buf_set_u32(code, 0, 32, ARMV5_T_BKPT(0x11));
-               else
-               /* length == 3: Thumb-2 breakpoint, actual encoding is
-                * a regular Thumb BKPT instruction but we replace a
-                * 32bit Thumb-2 instruction, so fix-up the breakpoint
-                * length
-                */
-               if (breakpoint->length == 3) {
+               } else if (breakpoint->length == 3) {
+                       /* length == 3: Thumb-2 breakpoint, actual encoding is
+                        * a regular Thumb BKPT instruction but we replace a
+                        * 32bit Thumb-2 instruction, so fix-up the breakpoint
+                        * length
+                        */
                        buf_set_u32(code, 0, 32, ARMV5_T_BKPT(0x11));
                        breakpoint->length = 4;
-               } else
+               } else {
                        /* length == 4, normal ARM breakpoint */
                        buf_set_u32(code, 0, 32, ARMV5_BKPT(0x11));
+               }
 
                retval = target_read_memory(target,
                                breakpoint->address & 0xFFFFFFFE,
@@ -1348,8 +1348,7 @@ static int cortex_a_set_breakpoint(struct target *target,
                        return retval;
 
                /* make sure data cache is cleaned & invalidated down to PoC */
-               armv7a_cache_flush_virt(target, breakpoint->address,
-                                               breakpoint->length);
+               armv7a_cache_flush_virt(target, breakpoint->address, breakpoint->length);
 
                retval = target_write_memory(target,
                                breakpoint->address & 0xFFFFFFFE,
@@ -1358,10 +1357,8 @@ static int cortex_a_set_breakpoint(struct target *target,
                        return retval;
 
                /* update i-cache at breakpoint location */
-               armv7a_l1_d_cache_inval_virt(target, breakpoint->address,
-                                       breakpoint->length);
-               armv7a_l1_i_cache_inval_virt(target, breakpoint->address,
-                                                breakpoint->length);
+               armv7a_l1_d_cache_inval_virt(target, breakpoint->address, breakpoint->length);
+               armv7a_l1_i_cache_inval_virt(target, breakpoint->address, breakpoint->length);
 
                breakpoint->is_set = true;
        }
index dd40558a1804239a2dcc96b021b536870da4c3f3..fcb7042cb156748107b83ee1635f35722e2f8f28 100644 (file)
@@ -2357,7 +2357,7 @@ COMMAND_HANDLER(mips32_handle_scan_delay_command)
        if (CMD_ARGC == 1)
                COMMAND_PARSE_NUMBER(uint, CMD_ARGV[0], ejtag_info->scan_delay);
        else if (CMD_ARGC > 1)
-                       return ERROR_COMMAND_SYNTAX_ERROR;
+               return ERROR_COMMAND_SYNTAX_ERROR;
 
        command_print(CMD, "scan delay: %d nsec", ejtag_info->scan_delay);
        if (ejtag_info->scan_delay >= MIPS32_SCAN_DELAY_LEGACY_MODE) {
index ad98089614cd6e4577fefe5d5b057ad3996baa83..1543de355e7228e4a4de5364b34b18e3034c7694 100644 (file)
@@ -1397,7 +1397,7 @@ COMMAND_HANDLER(mips_m4k_handle_scan_delay_command)
        if (CMD_ARGC == 1)
                COMMAND_PARSE_NUMBER(uint, CMD_ARGV[0], ejtag_info->scan_delay);
        else if (CMD_ARGC > 1)
-                       return ERROR_COMMAND_SYNTAX_ERROR;
+               return ERROR_COMMAND_SYNTAX_ERROR;
 
        command_print(CMD, "scan delay: %d nsec", ejtag_info->scan_delay);
        if (ejtag_info->scan_delay >= MIPS32_SCAN_DELAY_LEGACY_MODE) {
index 2b3466dacb142af4cf995fd451e94753f2cf7011..fb5c81f061fa039cdb9f4ff9333783713ea16322 100644 (file)
@@ -689,15 +689,13 @@ static int stm8_write_flash(struct target *target, enum mem_type type,
                        if (stm8->flash_ncr2)
                                stm8_write_u8(target, stm8->flash_ncr2, ~(PRG + opt));
                        blocksize = blocksize_param;
-               } else
-               if ((bytecnt >= 4) && ((address & 0x3) == 0)) {
+               } else if ((bytecnt >= 4) && ((address & 0x3) == 0)) {
                        if (stm8->flash_cr2)
                                stm8_write_u8(target, stm8->flash_cr2, WPRG + opt);
                        if (stm8->flash_ncr2)
                                stm8_write_u8(target, stm8->flash_ncr2, ~(WPRG + opt));
                        blocksize = 4;
-               } else
-               if (blocksize != 1) {
+               } else if (blocksize != 1) {
                        if (stm8->flash_cr2)
                                stm8_write_u8(target, stm8->flash_cr2, opt);
                        if (stm8->flash_ncr2)
@@ -1552,8 +1550,8 @@ static int stm8_set_watchpoint(struct target *target,
        }
 
        if (watchpoint->length != 1) {
-                       LOG_ERROR("Only watchpoints of length 1 are supported");
-                       return ERROR_TARGET_UNALIGNED_ACCESS;
+               LOG_ERROR("Only watchpoints of length 1 are supported");
+               return ERROR_TARGET_UNALIGNED_ACCESS;
        }
 
        enum hw_break_type enable = 0;
index 74a4dcfde1d25093a425e1c3009215fd9a21ceb7..88275043edc2355c8d88d011c27fac1f6913692e 100644 (file)
@@ -749,10 +749,10 @@ COMMAND_HANDLER(handle_xsvf_command)
                                int delay;
 
                                if (read(xsvf_fd, &wait_local, 1) < 0
-                                       || read(xsvf_fd, &end, 1) < 0
-                                       || read(xsvf_fd, delay_buf, 4) < 0) {
-                                               do_abort = 1;
-                                               break;
+                                               || read(xsvf_fd, &end, 1) < 0
+                                               || read(xsvf_fd, delay_buf, 4) < 0) {
+                                       do_abort = 1;
+                                       break;
                                }
 
                                wait_state = xsvf_to_tap(wait_local);