Fix fd/memory leak on error return from openconnect_open_https()

Spotted by Coverity.

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>

diff --git a/gnutls.c b/gnutls.c
index 3513ccb1ad8f5efbaa52444ef1b5dc8d48ea098c..aa02e0d7340aed0eea803b903c355f12e2857c7a 100644 (file)
--- a/gnutls.c
+++ b/gnutls.c
@@ -1843,6 +1843,9 @@ int openconnect_open_https(struct openconnect_info *vpninfo)
                vpn_progress(vpninfo, PRG_ERR,
                             _("Failed to set TLS priority string: %s\n"),
                             gnutls_strerror(err));
+               gnutls_deinit(vpninfo->https_sess);
+               vpninfo->https_sess = NULL;
+               close(ssl_sock);
                return -EIO;
        }