HID: pidff: Add FIX_WHEEL_DIRECTION quirk

Most steering wheels simply ignore DIRECTION field, but some try to be
compliant with the PID standard and use it in force calculations. Games
often ignore setting this field properly and/or there can be issues with
dinput8 -> wine -> SDL -> Linux API translation, and this value can be
incorrect. This can lead to partial/complete loss of Force Feedback or
even unexpected force reversal.

Sadly, this quirk can't be detected automatically without sending out
effects that would move an axis.

This fixes FFB on Moza Racing devices and others where effect direction
is not simply ignored.

Signed-off-by: Tomasz Pakuła <tomasz.pakula.oficjalny@gmail.com>
Reviewed-by: Michał Kopeć <michal@nozomi.space>
Reviewed-by: Paul Dino Jones <paul@spacefreak18.xyz>
Signed-off-by: Jiri Kosina <jkosina@suse.com>

diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c
index 298a971c63fdce83374a37577f2cd42023248666..9e03dfb2b1e7ee974d4e5221b5e107f3928b7d72 100644 (file)
--- a/drivers/hid/usbhid/hid-pidff.c
+++ b/drivers/hid/usbhid/hid-pidff.c
@@ -136,6 +136,9 @@ static const u8 pidff_block_load_status[] = { 0x8c, 0x8d };
 #define PID_EFFECT_STOP                1
 static const u8 pidff_effect_operation_status[] = { 0x79, 0x7b };
 
+/* Polar direction 90 degrees (North) */
+#define PIDFF_FIXED_WHEEL_DIRECTION    0x4000
+
 struct pidff_usage {
        struct hid_field *field;
        s32 *value;
@@ -337,9 +340,12 @@ static void pidff_set_effect_report(struct pidff_device *pidff,
        pidff->set_effect[PID_GAIN].value[0] =
                pidff->set_effect[PID_GAIN].field->logical_maximum;
        pidff->set_effect[PID_DIRECTION_ENABLE].value[0] = 1;
-       pidff->effect_direction->value[0] =
-               pidff_rescale(effect->direction, 0xffff,
-                               pidff->effect_direction);
+
+       /* Use fixed direction if needed */
+       pidff->effect_direction->value[0] = pidff_rescale(
+               pidff->quirks & HID_PIDFF_QUIRK_FIX_WHEEL_DIRECTION ?
+               PIDFF_FIXED_WHEEL_DIRECTION : effect->direction,
+               0xffff, pidff->effect_direction);
 
        /* Omit setting delay field if it's missing */
        if (!(pidff->quirks & HID_PIDFF_QUIRK_MISSING_DELAY))

diff --git a/include/linux/hid.h b/include/linux/hid.h
index 31dfe9ed5394bd4752770004d2284ca5a1396b38..7a55accf689e020817191a8001c44b2b92a46c57 100644 (file)
--- a/include/linux/hid.h
+++ b/include/linux/hid.h
@@ -1234,6 +1234,7 @@ int hid_pidff_init_with_quirks(struct hid_device *hid, __u32 initial_quirks);
 #define HID_PIDFF_QUIRK_MISSING_DELAY          BIT(0)
 #define HID_PIDFF_QUIRK_MISSING_PBO            BIT(1)
 #define HID_PIDFF_QUIRK_PERMISSIVE_CONTROL     BIT(2)
+#define HID_PIDFF_QUIRK_FIX_WHEEL_DIRECTION    BIT(3)
 
 #define dbg_hid(fmt, ...) pr_debug("%s: " fmt, __FILE__, ##__VA_ARGS__)