]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
thermal: tegra: Simplify with scoped for each OF child loop
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thu, 10 Oct 2024 18:06:21 +0000 (20:06 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 26 Nov 2024 12:28:43 +0000 (13:28 +0100)
Use scoped for_each_child_of_node_scoped() when iterating over device
nodes to make code a bit simpler.

Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://patch.msgid.link/20241010-b4-cleanup-h-of-node-put-thermal-v4-5-bfbe29ad81f4@linaro.org
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/thermal/tegra/soctherm.c

index 6f1501e3fcc4c09b1c5f0dc3526176ededc07588..2c5ddf0db40c6e7e021d84974afbcba5d9ebbe0c 100644 (file)
@@ -1651,7 +1651,7 @@ static void soctherm_init_hw_throt_cdev(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
        struct tegra_soctherm *ts = dev_get_drvdata(dev);
-       struct device_node *np_stc, *np_stcc;
+       struct device_node *np_stc;
        const char *name;
        int i;
 
@@ -1668,7 +1668,7 @@ static void soctherm_init_hw_throt_cdev(struct platform_device *pdev)
                return;
        }
 
-       for_each_child_of_node(np_stc, np_stcc) {
+       for_each_child_of_node_scoped(np_stc, np_stcc) {
                struct soctherm_throt_cfg *stc;
                struct thermal_cooling_device *tcd;
                int err;
@@ -1683,7 +1683,6 @@ static void soctherm_init_hw_throt_cdev(struct platform_device *pdev)
 
                if (stc->init) {
                        dev_err(dev, "throttle-cfg: %s: redefined!\n", name);
-                       of_node_put(np_stcc);
                        break;
                }