]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
ice: use generic unrolled_count() macro
authorAlexander Lobakin <aleksander.lobakin@intel.com>
Thu, 6 Feb 2025 18:26:28 +0000 (19:26 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 11 Feb 2025 01:54:43 +0000 (17:54 -0800)
ice, same as i40e, has a custom loop unrolling macros for unrolling
Tx descriptors filling on XSk xmit.
Replace ice defs with generic unrolled_count(), which is also more
convenient as it allows passing defines as its argument, not hardcoded
values, while the loop declaration will still be usual for-loop.

Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Link: https://patch.msgid.link/20250206182630.3914318-4-aleksander.lobakin@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/intel/ice/ice_xsk.c
drivers/net/ethernet/intel/ice/ice_xsk.h

index 8975d2971bc3778aad8898e334ce1d759618fd32..a3a4eaa17739ae084ccbe2cc75f3d10ca1be3fdc 100644 (file)
@@ -2,6 +2,7 @@
 /* Copyright (c) 2019, Intel Corporation. */
 
 #include <linux/bpf_trace.h>
+#include <linux/unroll.h>
 #include <net/xdp_sock_drv.h>
 #include <net/xdp.h>
 #include "ice.h"
@@ -989,7 +990,8 @@ static void ice_xmit_pkt_batch(struct ice_tx_ring *xdp_ring,
        struct ice_tx_desc *tx_desc;
        u32 i;
 
-       loop_unrolled_for(i = 0; i < PKTS_PER_BATCH; i++) {
+       unrolled_count(PKTS_PER_BATCH)
+       for (i = 0; i < PKTS_PER_BATCH; i++) {
                dma_addr_t dma;
 
                dma = xsk_buff_raw_get_dma(xsk_pool, descs[i].addr);
index 45adeb513253a0d12e11251c4070855451a7ed44..8dc5d55e26c5209e051bd3a2428266bfb451de3a 100644 (file)
@@ -7,14 +7,6 @@
 
 #define PKTS_PER_BATCH 8
 
-#ifdef __clang__
-#define loop_unrolled_for _Pragma("clang loop unroll_count(8)") for
-#elif __GNUC__ >= 8
-#define loop_unrolled_for _Pragma("GCC unroll 8") for
-#else
-#define loop_unrolled_for for
-#endif
-
 struct ice_vsi;
 
 #ifdef CONFIG_XDP_SOCKETS