]> www.infradead.org Git - linux.git/commitdiff
drm/xe/oa: Add input fence dependencies
authorAshutosh Dixit <ashutosh.dixit@intel.com>
Tue, 22 Oct 2024 20:03:48 +0000 (13:03 -0700)
committerAshutosh Dixit <ashutosh.dixit@intel.com>
Wed, 23 Oct 2024 19:42:16 +0000 (12:42 -0700)
Add input fence dependencies which will make OA configuration wait till
these dependencies are met (till input fences signal).

v2: Change add_deps arg to xe_oa_submit_bb from bool to enum (Matt Brost)

Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241022200352.1192560-4-ashutosh.dixit@intel.com
drivers/gpu/drm/xe/xe_oa.c

index 3f1de88c5f882c1088db08ccec8262ce3c87b99e..380ee1e6325109a1a53665cfd572365a6c459c8d 100644 (file)
 #define DEFAULT_POLL_PERIOD_NS (NSEC_PER_SEC / DEFAULT_POLL_FREQUENCY_HZ)
 #define XE_OA_UNIT_INVALID U32_MAX
 
+enum xe_oa_submit_deps {
+       XE_OA_SUBMIT_NO_DEPS,
+       XE_OA_SUBMIT_ADD_DEPS,
+};
+
 struct xe_oa_reg {
        struct xe_reg addr;
        u32 value;
@@ -575,7 +580,8 @@ static __poll_t xe_oa_poll(struct file *file, poll_table *wait)
        return ret;
 }
 
-static struct dma_fence *xe_oa_submit_bb(struct xe_oa_stream *stream, struct xe_bb *bb)
+static struct dma_fence *xe_oa_submit_bb(struct xe_oa_stream *stream, enum xe_oa_submit_deps deps,
+                                        struct xe_bb *bb)
 {
        struct xe_sched_job *job;
        struct dma_fence *fence;
@@ -588,11 +594,22 @@ static struct dma_fence *xe_oa_submit_bb(struct xe_oa_stream *stream, struct xe_
                goto exit;
        }
 
+       if (deps == XE_OA_SUBMIT_ADD_DEPS) {
+               for (int i = 0; i < stream->num_syncs && !err; i++)
+                       err = xe_sync_entry_add_deps(&stream->syncs[i], job);
+               if (err) {
+                       drm_dbg(&stream->oa->xe->drm, "xe_sync_entry_add_deps err %d\n", err);
+                       goto err_put_job;
+               }
+       }
+
        xe_sched_job_arm(job);
        fence = dma_fence_get(&job->drm.s_fence->finished);
        xe_sched_job_push(job);
 
        return fence;
+err_put_job:
+       xe_sched_job_put(job);
 exit:
        return ERR_PTR(err);
 }
@@ -670,7 +687,7 @@ static int xe_oa_modify_ctx_image(struct xe_oa_stream *stream, struct xe_lrc *lr
 
        xe_oa_store_flex(stream, lrc, bb, flex, count);
 
-       fence = xe_oa_submit_bb(stream, bb);
+       fence = xe_oa_submit_bb(stream, XE_OA_SUBMIT_NO_DEPS, bb);
        if (IS_ERR(fence)) {
                err = PTR_ERR(fence);
                goto free_bb;
@@ -699,7 +716,7 @@ static int xe_oa_load_with_lri(struct xe_oa_stream *stream, struct xe_oa_reg *re
 
        write_cs_mi_lri(bb, reg_lri, 1);
 
-       fence = xe_oa_submit_bb(stream, bb);
+       fence = xe_oa_submit_bb(stream, XE_OA_SUBMIT_NO_DEPS, bb);
        if (IS_ERR(fence)) {
                err = PTR_ERR(fence);
                goto free_bb;
@@ -949,7 +966,7 @@ static int xe_oa_emit_oa_config(struct xe_oa_stream *stream, struct xe_oa_config
                goto exit;
        }
 
-       fence = xe_oa_submit_bb(stream, oa_bo->bb);
+       fence = xe_oa_submit_bb(stream, XE_OA_SUBMIT_ADD_DEPS, oa_bo->bb);
        if (IS_ERR(fence)) {
                err = PTR_ERR(fence);
                goto exit;