]> www.infradead.org Git - nvme.git/commitdiff
LoongArch: KVM: Select huge page only if secondary mmu supports it
authorBibo Mao <maobibo@loongson.cn>
Tue, 9 Jul 2024 08:25:51 +0000 (16:25 +0800)
committerHuacai Chen <chenhuacai@loongson.cn>
Tue, 9 Jul 2024 08:25:51 +0000 (16:25 +0800)
Currently page level selection about secondary mmu depends on memory
slot and page level about host mmu. There will be problems if page level
of secondary mmu is zero already. Huge page cannot be selected if there is
normal page mapped in secondary mmu already, since it is not supported to
merge normal pages into huge pages now.

So page level selection should depend on the following three conditions.
 1. Memslot is aligned for huge page and vm is not migrating.
 2. Page level of host mmu is also huge page.
 3. Page level of secondary mmu is suituable for huge page.

Signed-off-by: Bibo Mao <maobibo@loongson.cn>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
arch/loongarch/kvm/mmu.c

index 431a26eda47323a5f36382facc2d249159784e55..576bc90292f0817432d4a85e6328d9ca82c7b21e 100644 (file)
@@ -858,10 +858,20 @@ retry:
 
        /* Disable dirty logging on HugePages */
        level = 0;
-       if (!fault_supports_huge_mapping(memslot, hva, write)) {
-               level = 0;
-       } else {
+       if (fault_supports_huge_mapping(memslot, hva, write)) {
+               /* Check page level about host mmu*/
                level = host_pfn_mapping_level(kvm, gfn, memslot);
+               if (level == 1) {
+                       /*
+                        * Check page level about secondary mmu
+                        * Disable hugepage if it is normal page on
+                        * secondary mmu already
+                        */
+                       ptep = kvm_populate_gpa(kvm, NULL, gpa, 0);
+                       if (ptep && !kvm_pte_huge(*ptep))
+                               level = 0;
+               }
+
                if (level == 1) {
                        gfn = gfn & ~(PTRS_PER_PTE - 1);
                        pfn = pfn & ~(PTRS_PER_PTE - 1);