]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
iio: temperature: tmp006: fix information leak in triggered buffer
authorJavier Carrasco <javier.carrasco.cruz@gmail.com>
Tue, 3 Dec 2024 23:55:31 +0000 (00:55 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 8 Dec 2024 16:51:35 +0000 (16:51 +0000)
The 'scan' local struct is used to push data to user space from a
triggered buffer, but it has a hole between the two 16-bit data channels
and the timestamp. This hole is never initialized.

Initialize the struct to zero before using it to avoid pushing
uninitialized information to userspace.

Fixes: 91f75ccf9f03 ("iio: temperature: tmp006: add triggered buffer support")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Link: https://patch.msgid.link/20241204-iio_memset_scan_holes-v2-1-3f941592a76d@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/temperature/tmp006.c

index 0c844137d7aa907429a125687f1c91f697d1b878..02b27f471baae587763641dcae1e1777d8e38842 100644 (file)
@@ -252,6 +252,8 @@ static irqreturn_t tmp006_trigger_handler(int irq, void *p)
        } scan;
        s32 ret;
 
+       memset(&scan, 0, sizeof(scan));
+
        ret = i2c_smbus_read_word_data(data->client, TMP006_VOBJECT);
        if (ret < 0)
                goto err;