dm thin metadata: don't issue prefetches if a transaction abort has failed

Orabug: stable_rc4

[ Upstream commit 2eae9e4489b4cf83213fa3bd508b5afca3f01780 ]

If a transaction abort has failed then we can no longer use the metadata
device.  Typically this happens if the superblock is unreadable.

This fix addresses a crash seen during metadata device failure testing.

Fixes: 8a01a6af75 ("dm thin: prefetch missing metadata pages")
Cc: stable@vger.kernel.org # 3.19+
Signed-off-by: Joe Thornber <ejt@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
(cherry picked from commit 78243d0a1221f06af96a8952cd5ac71cd1fe5376)

Signed-off-by: Dan Duval <dan.duval@oracle.com>

diff --git a/drivers/md/dm-thin-metadata.c b/drivers/md/dm-thin-metadata.c
index cde1d6749017cb23b586b50ef60bdf30ad59772e..9b4f73e55d7c1693185c208b45bc6a3887d692e7 100644 (file)
--- a/drivers/md/dm-thin-metadata.c
+++ b/drivers/md/dm-thin-metadata.c
@@ -1803,5 +1803,8 @@ bool dm_pool_metadata_needs_check(struct dm_pool_metadata *pmd)
 
 void dm_pool_issue_prefetches(struct dm_pool_metadata *pmd)
 {
-       dm_tm_issue_prefetches(pmd->tm);
+       down_read(&pmd->root_lock);
+       if (!pmd->fail_io)
+               dm_tm_issue_prefetches(pmd->tm);
+       up_read(&pmd->root_lock);
 }