scsi: bfa: Rework bfad_reset_sdev_bflags()

Since commit f93ed747e2c7 ("scsi: core: Release SCSI devices
synchronously") it is no longer allowed to call scsi_device_put() from
atomic context.

Rework bfad_reset_sdev_bflags() such that scsi_device_put() is no longer
called. This fixes the following smatch warning:

drivers/scsi/bfa/bfad_bsg.c:2551 bfad_iocmd_lunmask_reset_lunscan_mode() warn: sleeping in atomic context

bfad_iocmd_lunmask() <- disables preempt
-> bfad_iocmd_lunmask_reset_lunscan_mode()
   -> scsi_device_put()

Cc: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
Cc: Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20221031224728.2607760-5-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/bfa/bfad_bsg.c b/drivers/scsi/bfa/bfad_bsg.c
index 73754032e25c09f7c634639db71ecf56a7563b46..79d4f7ee5bcb05c6073544c936f7e945f1f367b4 100644 (file)
--- a/drivers/scsi/bfa/bfad_bsg.c
+++ b/drivers/scsi/bfa/bfad_bsg.c
@@ -2553,18 +2553,20 @@ static void bfad_reset_sdev_bflags(struct bfad_im_port_s *im_port,
        const u32 scan_flags = BLIST_NOREPORTLUN | BLIST_SPARSELUN;
        struct bfad_itnim_s *itnim;
        struct scsi_device *sdev;
+       unsigned long flags;
 
+       spin_lock_irqsave(im_port->shost->host_lock, flags);
        list_for_each_entry(itnim, &im_port->itnim_mapped_list, list_entry) {
-               sdev = scsi_device_lookup(im_port->shost, itnim->channel,
-                                         itnim->scsi_tgt_id, 0);
+               sdev = __scsi_device_lookup(im_port->shost, itnim->channel,
+                                           itnim->scsi_tgt_id, 0);
                if (sdev) {
                        if (lunmask_cfg == BFA_TRUE)
                                sdev->sdev_bflags |= scan_flags;
                        else
                                sdev->sdev_bflags &= ~scan_flags;
-                       scsi_device_put(sdev);
                }
        }
+       spin_unlock_irqrestore(im_port->shost->host_lock, flags);
 }
 
 /* Function to reset the LUN SCAN mode */